Modernize plugin build #204
Conversation
| <extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd"> | ||
| <extension> | ||
| <groupId>io.jenkins.tools.incrementals</groupId> | ||
| <artifactId>git-changelist-maven-extension</artifactId> | ||
| <version>1.7</version> | ||
| </extension> | ||
| </extensions> |
There was a problem hiding this comment.
| -Pconsume-incrementals | ||
| -Pmight-produce-incrementals |
There was a problem hiding this comment.
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], |
There was a problem hiding this comment.
Latest recommendation from the archetype.
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>plugin</artifactId> | ||
| <version>4.52</version> | ||
| <version>4.79</version> |
There was a problem hiding this comment.
Latest version at the time of this writing.
| </parent> | ||
|
|
||
| <artifactId>p4</artifactId> | ||
| <version>1.15.2-SNAPSHOT</version> | ||
| <version>${revision}${changelist}</version> |
There was a problem hiding this comment.
| @@ -129,7 +164,6 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>structs</artifactId> | |||
| <version>324.va_f5d6774f3a_d</version> | |||
| @@ -169,7 +203,7 @@ | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>multiple-scms</artifactId> | |||
| <version>0.6</version> | |||
| <version>0.8</version> | |||
| <groupId>io.jenkins.plugins</groupId> | ||
| <artifactId>json-api</artifactId> |
There was a problem hiding this comment.
| @@ -35,7 +35,7 @@ static public ListBoxModel doFillCredentialItems() { | |||
| acl, domain); | |||
|
|
|||
| if (credentials.isEmpty()) { | |||
| list.add("Select credential...", null); | |||
| list.add("Select credential...", ""); | |||
There was a problem hiding this comment.
Fixing a serious SpotBugs warning:
[ERROR] High: Null passed for non-null parameter of
hudson.util.ListBoxModel.add(String, String)inorg.jenkinsci.plugins.p4.credentials.P4CredentialsImpl.doFillCredentialItems()[org.jenkinsci.plugins.p4.credentials.P4CredentialsImpl] AtP4CredentialsImpl.java:[line 38]NP_NONNULL_PARAM_VIOLATION
| import com.gargoylesoftware.htmlunit.html.HtmlForm; | ||
| import com.gargoylesoftware.htmlunit.html.HtmlInput; | ||
| import com.gargoylesoftware.htmlunit.html.HtmlPage; | ||
| import org.htmlunit.html.HtmlForm; |
There was a problem hiding this comment.
Adapting to upstream package rename.
|
Thanks @basil for enhancing the plugin. We will add these changes |
https://www.jenkins.io/doc/developer/tutorial-improve/
Testing done
mvn clean verify -Dtest=InjectedTest