Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 3 unnecessary stubbings from KubernetesEngineBuilderClusterTest.java #350

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ARUS2023
Copy link

Testing done

Submitter checklist

Preview Give feedback

In our analysis of the project, we observed that

  1. 2 unnecessary stubbings which stubbed containerClient method and listAllClusters method in setUpClusterDescriptor are created but are never executed by the test KubernetesEngineBuilderClusterTest.testDoCheckClusterMessageWithEmptyProjectId;
  2. 3 unnecessary stubbings which stubbed getClientFactory method, containerClient method and listAllClusters method in setUpClusterDescriptor are created but are never executed by 3 tests KubernetesEngineBuilderClusterTest.testDoFillClusterItemsEmptyWithEmptyCredentialsId, KubernetesEngineBuilderClusterTest.testDoFillClusterItemsEmptyWithEmptyProjectId,KubernetesEngineBuilderClusterTest.testDoCheckClusterMessageWithEmptyCredentialsId.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant