Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 13 unnecessary stubbings from InstanceConfigurationTest.java #412

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ARUS2023
Copy link

Testing done

Submitter checklist

Preview Give feedback

In our analysis of the project, we observed that

  1. 12 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 4 tests InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.testClient. [See changes in InstanceConfigurationTest.java]

  2. 10 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method in init are created but are never executed by 4 tests InstanceConfigurationTest.descriptorBootDiskSizeValidation, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.testClient; [See changes in SecondInstanceConfigurationTest.java]

  3. 13 unnecessary stubbings which stubbed listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 3 tests InstanceConfigurationTest.descriptorBootDiskSizeValidation, InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testClient; [See changes in ThirdInstanceConfigurationTest.java]

  4. 11 unnecessary stubbings which stubbed listRegions method, listZones method, listMachineTypes method, listCpuPlatforms method, listBootDiskTypes method, getImage method, listImages method, listAcceleratorTypes method, listNetworks method, listSubnetworks method, getProjectId method, getClient method, getTemplate method in init are created but are never executed by 4 tests InstanceConfigurationTest.testInstanceMetadata, InstanceConfigurationTest.testInstanceModel, InstanceConfigurationTest.testConfigRoundtrip, InstanceConfigurationTest.descriptorBootDiskSizeValidation. [See changes in FourthInstanceConfigurationTest.java]

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html). We propose below a solution to remove the unnecessary stubbings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant