-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/merge request hooks behavior #1319
Fix/merge request hooks behavior #1319
Conversation
Hi @markyjackson-taulia (sorry for the 2 year late ping!!) and @basil (as the most active contributor currently), I've fixed the CI from #869 (comment) . Would you be able to take a look if you have the time? edit: never mind, sorry for the tags, I see there are no active maintainers anymore 😿 |
Hi @omehegan ! Would you be able to take a look at this? Sorry, just trying to get this resolved. |
@jbpratt I am no longer maintaining this plugin and no longer have permissions to release it. If the changes from this PR work, you can consider adopting the plugin to merge and release the PR. The "Contributing to Open Source" workshop from DevOps World 2021 is a useful starting point for new maintainers. That document includes links to a five part video series that illustrates many of the steps. If the plugin is crucial to your work, you may want to ask your employer to support your work efforts by allowing you to adopt the plugin. |
4eaa2db
to
3ad2cd1
Compare
State - closed, Action - close
we set it on 1st place because the more important type of hook than flag approved or not. Also update action often came with opened state.
Signed-off-by: Brady Pratt <[email protected]>
35308c3
to
2e9bed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @jbpratt for the contribution
Fixes #705.
This merge request builds onto #869 fixing the remaining test that was failing.
Thank you to @Osmyslitelny for the original fix!