Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/merge request hooks behavior #1319

Merged
merged 8 commits into from
Jan 31, 2023

Conversation

jbpratt
Copy link
Contributor

@jbpratt jbpratt commented Jul 25, 2022

Fixes #705.

This merge request builds onto #869 fixing the remaining test that was failing.

Thank you to @Osmyslitelny for the original fix!

@jbpratt jbpratt requested a review from a team as a code owner July 25, 2022 13:03
@jbpratt
Copy link
Contributor Author

jbpratt commented Jul 26, 2022

Hi @markyjackson-taulia (sorry for the 2 year late ping!!) and @basil (as the most active contributor currently), I've fixed the CI from #869 (comment) . Would you be able to take a look if you have the time?

edit: never mind, sorry for the tags, I see there are no active maintainers anymore 😿

@jbpratt
Copy link
Contributor Author

jbpratt commented Jul 26, 2022

Hi @omehegan ! Would you be able to take a look at this? Sorry, just trying to get this resolved.

@basil
Copy link
Member

basil commented Jul 26, 2022

@jbpratt I am no longer maintaining this plugin and no longer have permissions to release it. If the changes from this PR work, you can consider adopting the plugin to merge and release the PR. The "Contributing to Open Source" workshop from DevOps World 2021 is a useful starting point for new maintainers. That document includes links to a five part video series that illustrates many of the steps. If the plugin is crucial to your work, you may want to ask your employer to support your work efforts by allowing you to adopt the plugin.

@jbpratt jbpratt force-pushed the fix/merge_request_hooks_behavior branch from 4eaa2db to 3ad2cd1 Compare September 20, 2022 12:29
YaraslauSupanitski and others added 5 commits October 6, 2022 16:21
State - closed, Action - close
we set it on 1st place because the more important type of hook than flag approved or not.
Also update action often came with opened state.
@jbpratt jbpratt force-pushed the fix/merge_request_hooks_behavior branch from 35308c3 to 2e9bed3 Compare October 6, 2022 21:21
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Nov 22, 2022
@krisstern krisstern self-assigned this Jan 31, 2023
Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @jbpratt for the contribution

@krisstern krisstern merged commit 8ec69c7 into jenkinsci:master Jan 31, 2023
@jbpratt jbpratt deleted the fix/merge_request_hooks_behavior branch January 31, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "Never" option for "Rebuild open Merge Requests" does not prevent a build
6 participants