Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stub rather than a real WorkflowJob instance in ScmResolverTest #572

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 16, 2024

CloudBees CI PCT runs indicate that this is broken by jenkinsci/jenkins#10042. Even on the current core version, it prints numerous stack traces because code is trying to run which cannot work in a Mockito-based environment. Please do not use Mockito to write tests for Jenkins plugins; it causes unnecessary maintenance burdens for others. I could not easily confirm the behavior directly on current core versions because of the use of the nonstandard analysis-pom parent POM; please use the standard parent instead (this is also a source of difficulty for the Jenkins community).

@uhafner uhafner added the tests Enhancement of tests label Dec 17, 2024
@uhafner uhafner changed the title Disabling ScmResolverTest.shouldResolveScmForPipelineWithFlowNode Use a stub rather than a real Workflow instance in ScmResolverTest Dec 17, 2024
@uhafner uhafner changed the title Use a stub rather than a real Workflow instance in ScmResolverTest Use a stub rather than a real WorkflowJob instance in ScmResolverTest Dec 17, 2024
@uhafner uhafner merged commit b5c5df0 into jenkinsci:main Dec 17, 2024
28 checks passed
@uhafner
Copy link
Member

uhafner commented Dec 17, 2024

@jglick do you need a new release or are the tests executed from the main branch?

@jglick
Copy link
Member Author

jglick commented Dec 17, 2024

A new release would be needed so we can update jenkinsci/bom to prepare for the weekly core release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants