Add new feature Delete Artifacts with pattern#84

Open

nurgul212 wants to merge 111 commits intojenkinsci:masterfrom nurgul212:deletion-patterns

+881

Commits on Dec 28, 2023

Add new feature Delete Artifacts matching patterns

Nurgul Amat
authored and
damianszczepanik
committed
Replace 'touch' with 'writeFile' and 'mkdir' with 'dir'

Nurgul Amat
authored and
damianszczepanik
committed
Add a test 'testRemoveLastSlash_NoSlash()' to check archiveRootPath for codeCoverage purpose

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Extract method from private static final class to public static

Nurgul Amat
authored and
damianszczepanik
committed
Remove unused else if statement for directory handling

Nurgul Amat
authored and
damianszczepanik
committed
Add unit tests for getInclude & getExclude methods for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Add annotation to exclude checkRoles method from code coverage

Nurgul Amat
authored and
damianszczepanik
committed
the logic for deleting parent directory has been moved to a separate method 'deleteParentDirectories'

Nurgul Amat
authored and
damianszczepanik
committed
Extract method from private static final class to public static

Nurgul Amat
authored and
damianszczepanik
committed
Test: Add one unit test for 'isDirEmpty' method to improve code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Remove commented out code

Nurgul Amat
authored and
damianszczepanik
committed
Add annotation to exclude getInclude&Exclude, setInclude&Exclude methods from code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Fixed 'Assignment Branch Condition too high' issue by refactoring

Nurgul Amat
authored and
damianszczepanik
committed
Extract two lines of code into deleteFileAtPath() method

Nurgul Amat
authored and
damianszczepanik
committed
Extracted the logic that decides whether to delete a directory into a separate method called 'shouldDeleteDirectory'

Nurgul Amat
authored and
damianszczepanik
committed
Add a test for isDirEmpty method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Extract code block into a separate method called 'deleteFileOrLogError'

Nurgul Amat
authored and
damianszczepanik
committed
Remove '@generated ' annotation

Nurgul Amat
authored and
damianszczepanik
committed
Add unit tests for getInclude and getExclude methods for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Minor correction: Add a comment and IOExeption

Nurgul Amat
authored and
damianszczepanik
committed
Add tests for isDirEmpty method and checkRoles mehtod

Nurgul Amat
authored and
damianszczepanik
committed
update access modifier

Nurgul Amat
authored and
damianszczepanik
committed
Add unit test for deleteParentDirectories method

Nurgul Amat
authored and
damianszczepanik
committed
Formatting the test code

Nurgul Amat
authored and
damianszczepanik
committed
Fixed code defect

Nurgul Amat
authored and
damianszczepanik
committed
Refactoring the code to make it cleaner and easier to understand

Nurgul Amat
authored and
damianszczepanik
committed
Remove '// TODO Auto-generated method stub'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor deleteParentDirectories method for easy to write unit tests

Nurgul Amat
authored and
damianszczepanik
committed
Add unit tests for shouldDelete method and deleteDirecotry method

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: merge two unit tests

Nurgul Amat
authored and
damianszczepanik
committed
Move deleteFileOrLogError method inside Delete class for writing unit test

Nurgul Amat
authored and
damianszczepanik
committed
Added tests for deleteFileOrLogError method

Nurgul Amat
authored and
damianszczepanik
committed
Add a test for shouldDeleteDirectory method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Fix uncvovered line for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Fixed partially covered lines for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Covered one missing branch issue for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Fixing partialy covered statement

Nurgul Amat
authored and
damianszczepanik
committed
Create a parent directory that is not equal to archiveRootPath

Nurgul Amat
authored and
damianszczepanik
committed
Refacto shouldDeleteDirectory method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Rewrite a test for shouldDeleteDirectory method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Extract the common code lines and organize the test methods for better readability

Nurgul Amat
authored and
damianszczepanik
committed
remove .vscode/settings.json

Nurgul Amat
authored and
damianszczepanik
committed
remove 'pom copy.xml'

Nurgul Amat
authored and
damianszczepanik
committed
Add .vscode/settings.json to .gitignore list

Nurgul Amat
authored and
damianszczepanik
committed
update .gitignore list

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename 'LOGGER' to 'LOG' for naming convension

Nurgul Amat
authored and
damianszczepanik
committed
Removed 'LOGGER' and added new line at the end of file for consistency

Nurgul Amat
authored and
damianszczepanik
committed
Removed 'serialVersionUID'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename method from 'isInvalidDirectory' to 'isValidDirectory' to avoid using negation in method names

Nurgul Amat
authored and
damianszczepanik
committed
Test: Update assertion to test 'isValidDirecotry' method

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename method 'isDirEmpty' to 'isDirectoryEmpty' for improved clarity

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: update the test for 'isDirectoryEmpty' after renaming

Nurgul Amat
authored and
damianszczepanik
committed
Fix: Add space between ')' and '{' for consistent code style

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Reorganize the constructor, renamed 'vFile', added a comment to 'checkRoles' method, added back 'serialVerisonUID'

Nurgul Amat
authored and
damianszczepanik
committed
Update: updated the 'removeLastSeparator' method to ensure compatibility with Windows path separators '\'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename 'vFile' to 'file' in 'invoke' method

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: change access modifier to package-private for some methods

Nurgul Amat
authored and
damianszczepanik
committed
Test: Added a test for 'removeLastSlash' method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Test: Add a test for 'removeLastSlash' method with backslash for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Reorganize the 'constructor' to match the structure of other methods

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename 'removeLastSlash' method to 'removeLastFileSeparator' and update the code

Nurgul Amat
authored and
damianszczepanik
committed
Refator: Removed 'removeLastFileSeparator' method and replaced 'archiveRootPath' with 'archiveRootFile' of type File

Nurgul Amat
authored and
damianszczepanik
committed
Removed 'checkRoles' method

Nurgul Amat
authored and
damianszczepanik
committed
Removed unit tests associated with the 'removeLastFileSeparator' method

Nurgul Amat
authored and
damianszczepanik
committed
Removed unit test associated with the 'checkRoles' method

Nurgul Amat
authored and
damianszczepanik
committed
Replaced 'archiveRootPath' with 'archiveRootFile' of type File in unit test

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Removed 'incldue' and 'exclude' fields and their associated getters and setters

Nurgul Amat
authored and
damianszczepanik
committed
Fix: Corrected typo 'archiveRooFile' to 'archiveRootFile' and updated 'String' comparison to 'File'

Nurgul Amat
authored and
damianszczepanik
committed
Added back 'checkRoles' method with documentation

Nurgul Amat
authored and
damianszczepanik
committed
Added back the unit test for 'checkRoles' method

Nurgul Amat
authored and
damianszczepanik
committed
Removed redundant test methods

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: renamed 'include/exclude' to 'includePatterns/excludePatterns'

Nurgul Amat
authored and
damianszczepanik
committed
Renamed 'include/exclude' to 'includePatterns/excludePatterns' in config.jelly and help files

Nurgul Amat
authored and
damianszczepanik
committed
Renamed 'include/exclude' to 'includePatterns/excludePatterns' in jenkis files of the integraiton test

Nurgul Amat
authored and
damianszczepanik
committed
Renamed 'DeleteArtifactsWithPattern' to 'DeleteArtifactsMatchingPatterns' in jenkins files for integration test

Nurgul Amat
authored and
damianszczepanik
committed
Renamed all 'DeleteArtifactsWithPattern' to 'DeleteArtifactsMatchingPatterns'

Nurgul Amat
authored and
damianszczepanik
committed
Refacotr: Removed redundent code and organized the import statements

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Reorganize Import Statements

Nurgul Amat
authored and
damianszczepanik
committed
Replaced 'delete-artifacts-with-pattern-configuration.png' with 'delete-artifacts-matching-patterns-configuration.png'

Nurgul Amat
authored and
damianszczepanik
committed
Updated 'README' file in response to attribute name changes

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Avoid using intermediate assignment to fix 'Assignment Branch Condition too high' issue introduced in codebeat

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Simplify 'isDirectoryEmpty' method and updated unit tests

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: simplify directory comparison logic

Nurgul Amat
authored and
damianszczepanik
committed
A new serialVersionUID is auto-generated

Nurgul Amat
authored and
damianszczepanik
committed
Refactor error handling in 'deleteDirectory' method

Nurgul Amat
authored and
damianszczepanik
committed
Added/updated unit tests for 'deleteDirectory' method for code coverage

Nurgul Amat
authored and
damianszczepanik
committed
Addressed various warnings highlighted by IntelliJ IDEA

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Inline 'inValidDirectory' method and remove unnecessary tests

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Inline 'shouldDelete' and 'shouldDeleteDirectory' methods and remove test coverage

Nurgul Amat
authored and
damianszczepanik
committed
docs: Update comment for artifacts deletion matching patterns

Nurgul Amat
authored and
damianszczepanik
committed
chore: Add newline at the end of file

Nurgul Amat
authored and
damianszczepanik
committed
Test: Add coverage for null directory scenario

Nurgul Amat
authored and
damianszczepanik
committed
Update src/main/java/pl/damianszczepanik/jenkins/buildhistorymanager/model/actions/DeleteArtifactsMatchingPatternsAction.java

damianszczepanik
and
olivierdagenais
committed
Added new line at the end of file

Nurgul Amat
authored and
damianszczepanik
committed
Suggestion applied: Rename 'Delete' methed to 'DeleteFileCallable'

Nurgul Amat
authored and
damianszczepanik
committed
Renamed 'deleteInstance' to 'deleteFileCallableInstance'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Removed 'Set<File> directories' and the loop, simplified the code and aligned with the feedback that the loop is iterated only once.

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Delete the file first then handle empty directories; Renamed a method name

Nurgul Amat
authored and
damianszczepanik
committed
Removed serialVersionUID as it is not needed in the static class

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Renamed 'archiveRootFile' to 'archiveRootDirectory'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Renamed 'archiveRootDir' to 'archiveRootDirectory'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Renamed 'vRoot' to 'virtualRoot'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Moved 'isDirectoryEmpty' method into 'DeleteFileCallable' class and updated the tests to reflect the changes in the method location

Nurgul Amat
authored and
damianszczepanik
committed
Added 'serialVersionUID' since 'FileCallable' class is connected to Serializable'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Renamed 'hasValidParent' method to 'isArchiveRootDirectory' and refactor 'deleteParentDirectories' method to use 'isArchiveRootDirectory' check for directory traversal

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Removed 'directory != null' condition from while loop and updated the code coverage test accordingly

Nurgul Amat
authored and
damianszczepanik
committed
Added comments for 'deleteEmptyDirectoryAndParent' method for better code readability and understanding of its functionality.

Nurgul Amat
authored and
damianszczepanik
committed
Refactor 'isArchiveRootDirectory' method for improved readability and consistency.

Nurgul Amat
authored and
damianszczepanik
committed
Remove redundant file deletion logging

Nurgul Amat
authored and
damianszczepanik
committed
Added a comment for 'System.setProperty()'

Nurgul Amat
authored and
damianszczepanik
committed
Refactor: Rename the method names for asserting a file exists or not

Nurgul Amat
authored and
damianszczepanik
committed