JENKINS-65285 The iOS symbol upload was uploading a copy of the app, not the symbols file. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not the symbols file.
|
Is this pull request assumed to be merged? |
|
@subprogram It works for me; I've been using the plugin binary produced by the test build of this branch. There was a bug in the fix posted in the issue thread which this avoids. But, not sure who has authority to actually merge this. |
|
@carllindberg Yes, it works for me too. The current version of the plugin has a bug that leads to uploading a copy of the app instead of the symbols file in Android. I found the cause of the bug in the source code and then I found this branch :) I can confirm that this patch fixes the issue for Android as well as iOs builds. |
|
Could this please be merged and a release be made? |
|
Hi! Could this please be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue reported at https://issues.jenkins.io/browse/JENKINS-65285 . Thanks to Thomas Innes for debugging it; this is mostly his suggested code fixes in the issue, with unit test fixes added.