-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore upgrade tekton pipelines #1621
base: main
Are you sure you want to change the base?
Chore upgrade tekton pipelines #1621
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated. |
1c6af4b
to
fbb6538
Compare
0ccaa59
to
b22abab
Compare
b22abab
to
45cc04d
Compare
@JordanGoasdoue: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
According to https://github.com/tektoncd/pipeline/blob/main/docs/deprecations.md#v1beta1-deprecation the v1beta1 versions will be supported by tekton for a couple of years. So we should be able to support v1 and v1beta1 at the same time for a while, making the transition easier for us and our users. There seems to be code to convert from v1beta1 to v1. For example: https://github.com/tektoncd/pipeline/blob/main/pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go I think the easiest would be to use such methods in pkg/triggerconfig/inrepo/load_pipelinerun.go if apiVersion is tekton.dev/v1beta1 in the file. |
related to jenkins-x/jx#8683