fix: base ref #1618
Merged
fix: base ref #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated. |
msvticket
force-pushed
the
fix_baswsha
branch
from
4186bab to
e79f0f1
Compare
Skisocks
approved these changes
Nov 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Skisocks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baseRefOID field is used as the sha of the base ref. The problem is that the returned value for this field sometimes is another sha. Often I think it is the sha of the base when the PR was created, but sometimes it is the sha of a much older commit.
In this PR I replace the use of baseRefIOD with
This seems to always be the current sha of the base ref, which is what we want.
This should fix the issue reported here: https://kubernetes.slack.com/archives/C9MBGQJRH/p1728050746717079