Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow skipping report comments #1611

Merged

Conversation

Maximilien-R
Copy link
Contributor

@Maximilien-R Maximilien-R commented Jun 19, 2024

This PR is intended to allow you to pass the reporting process done in the Forghon controller while keeping the SCM status.

The need behind this feature is to limit calls to SCM API and avoid rate limiting issues.

@jenkins-x-bot
Copy link
Contributor

Hi @Maximilien-R. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@JordanGoasdoue
Copy link
Contributor

/ok-to-test

Fixed error: verifying github.com/jenkins-x/[email protected]: checksum mismatch
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JordanGoasdoue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JordanGoasdoue JordanGoasdoue merged commit 1d8c55f into jenkins-x:main Jun 19, 2024
3 of 4 checks passed
@Maximilien-R Maximilien-R deleted the feat/allow-skip-report-comment branch June 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants