New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get the baseRefSha from graphql to reduce rate consumption #1580

Merged

jenkins-x-bot merged 4 commits into jenkins-x:main from spring-financial-group:reduce-rate-consumption

Oct 31, 2023

Contributor

Skisocks commented Oct 31, 2023

We can get the pull requests baseRefSha from the graphql query, this should reduce the rate limit usage as we no longer need to hit the rest api for every PR returned by the initial graphql query. This also reduces the rate consumption for scms that don't support graphql as baseRefSha is already found in the initial rest query.

Skisocks added 3 commits

October 31, 2023 14:21


          fix: get baseRefSHA from graphql instead of rest

18a2a8c


          test: remove baseSHA test as now returned by graphql

be5f633


          fix: add baseRefOID to scmPR -> graphql conversion

d6221c3

jenkins-x-bot added the needs-ok-to-test label

Contributor

jenkins-x-bot commented Oct 31, 2023

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

jenkins-x-bot added the size/M label

Contributor Author

Skisocks commented Oct 31, 2023

/cc @tomhobson @msvticket

jenkins-x-bot requested review from msvticket and tomhobson

October 31, 2023 14:56

Member

msvticket commented Oct 31, 2023

/ok-to-test

jenkins-x-bot added ok-to-test and removed needs-ok-to-test labels

msvticket approved these changes

View reviewed changes

Contributor

jenkins-x-bot commented Oct 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msvticket]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jenkins-x-bot added the approved label

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

14 similar comments

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

17 similar comments

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

Contributor

jenkins-x-bot commented Oct 31, 2023

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]


          Merge branch 'main' into reduce-rate-consumption

13fc7da

jenkins-x-bot merged commit deb3b86 into jenkins-x:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ok-to-test size/M