feat: Add periodic job support

.lighthouse/jenkins-x/pullrequest.yaml

@@ -45,6 +45,13 @@ spec:
             source .jx/variables.sh
             cp /tekton/creds-secrets/tekton-container-registry-auth/.dockerconfigjson /kaniko/.docker/config.json
             /kaniko/executor $KANIKO_FLAGS --context=/workspace/source --dockerfile=docker/keeper/Dockerfile --destination=ghcr.io/jenkins-x/lighthouse-keeper:$VERSION --build-arg=VERSION=$VERSION
+        - name: build-container-build:strobe
+          resources: {}
+          script: |
+            #!/busybox/sh
+            source .jx/variables.sh
+            cp /tekton/creds-secrets/tekton-container-registry-auth/.dockerconfigjson /kaniko/.docker/config.json
+            /kaniko/executor $KANIKO_FLAGS --context=/workspace/source --dockerfile=docker/strobe/Dockerfile --destination=ghcr.io/jenkins-x/lighthouse-strobe:$VERSION --build-arg=VERSION=$VERSION
         - name: build-container-build:foghorn
           resources: {}
           script: |

.lighthouse/jenkins-x/release.yaml

@@ -45,6 +45,13 @@ spec:
             source .jx/variables.sh
             cp /tekton/creds-secrets/tekton-container-registry-auth/.dockerconfigjson /kaniko/.docker/config.json
             /kaniko/executor $KANIKO_FLAGS --context=/workspace/source --dockerfile=docker/keeper/Dockerfile --destination=ghcr.io/jenkins-x/lighthouse-keeper:$VERSION --destination=ghcr.io/jenkins-x/lighthouse-keeper:latest --build-arg=VERSION=$VERSION
+        - name: build-and-push-image:strobe
+          resources: {}
+          script: |
+            #!/busybox/sh
+            source .jx/variables.sh
+            cp /tekton/creds-secrets/tekton-container-registry-auth/.dockerconfigjson /kaniko/.docker/config.json
+            /kaniko/executor $KANIKO_FLAGS --context=/workspace/source --dockerfile=docker/strobe/Dockerfile --destination=ghcr.io/jenkins-x/lighthouse-strobe:$VERSION --destination=ghcr.io/jenkins-x/lighthouse-strobe:latest --build-arg=VERSION=$VERSION
         - name: build-and-push-image:foghorn
           resources: {}
           script: |

Makefile

@@ -8,6 +8,7 @@ POLLER_EXECUTABLE := poller
 KEEPER_EXECUTABLE := keeper
 FOGHORN_EXECUTABLE := foghorn
 GC_JOBS_EXECUTABLE := gc-jobs
+STROBE_EXECUTABLE := strobe
 TEKTON_CONTROLLER_EXECUTABLE := lighthouse-tekton-controller
 JENKINS_CONTROLLER_EXECUTABLE := jenkins-controller
 
@@ -16,6 +17,7 @@ POLLER_MAIN_SRC_FILE=cmd/poller/main.go
 KEEPER_MAIN_SRC_FILE=cmd/keeper/main.go
 FOGHORN_MAIN_SRC_FILE=cmd/foghorn/main.go
 GC_JOBS_MAIN_SRC_FILE=cmd/gc/main.go
+STROBE_MAIN_SRC_FILE=cmd/strobe/main.go
 TEKTON_CONTROLLER_MAIN_SRC_FILE=cmd/tektoncontroller/main.go
 JENKINS_CONTROLLER_MAIN_SRC_FILE=cmd/jenkins/main.go
 
@@ -32,7 +34,7 @@ GO_DEPENDENCIES := $(call rwildcard,pkg/,*.go) $(call rwildcard,cmd/,*.go)
 all: build test check docs ## Default rule, builds all binaries, runs tests and format checks
 
 .PHONY: build
-build: build-webhooks build-poller build-keeper build-foghorn build-tekton-controller build-gc-jobs build-jenkins-controller ## Builds all Lighthouse binaries native to your machine
+build: build-webhooks build-poller build-keeper build-foghorn build-gc-jobs build-periodics build-tekton-controller build-jenkins-controller ## Builds all Lighthouse binaries native to your machine
 
 .PHONY: build-webhooks
 build-webhooks: ## Build the webhooks controller binary for the native OS
@@ -54,6 +56,10 @@ build-foghorn: ## Build the foghorn controller binary for the native OS
 build-gc-jobs: ## Build the GC jobs binary for the native OS
 	$(GO) build -ldflags "$(GO_LDFLAGS)" -o bin/$(GC_JOBS_EXECUTABLE) $(GC_JOBS_MAIN_SRC_FILE)
 
+.PHONY: build-strobe
+build-strobe: ## Build the strobe controller binary for the native OS
+	$(GO) build -i -ldflags "$(GO_LDFLAGS)" -o bin/$(STROBE_EXECUTABLE) $(STROBE_MAIN_SRC_FILE)
+
 .PHONY: build-tekton-controller
 build-tekton-controller: ## Build the Tekton controller binary for the native OS
 	$(GO) build -ldflags "$(GO_LDFLAGS)" -o bin/$(TEKTON_CONTROLLER_EXECUTABLE) $(TEKTON_CONTROLLER_MAIN_SRC_FILE)
@@ -69,7 +75,7 @@ release: linux
 linux: build-linux
 
 .PHONY: build-linux
-build-linux: build-webhooks-linux build-poller-linux build-foghorn-linux build-gc-jobs-linux build-keeper-linux build-tekton-controller-linux build-jenkins-controller-linux ## Build all binaries for Linux
+build-linux: build-webhooks-linux build-poller-linux build-foghorn-linux build-gc-jobs-linux build-keeper-linux build-strobe-linux build-tekton-controller-linux build-jenkins-controller-linux ## Build all binaries for Linux
 
 .PHONY: build-webhooks-linux ## Build the webhook controller binary for Linux
 build-webhooks-linux:
@@ -91,6 +97,10 @@ build-foghorn-linux: ## Build the foghorn controller binary for Linux
 build-gc-jobs-linux: ## Build the GC jobs binary for Linux
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 $(GO) build -ldflags "$(GO_LDFLAGS)" -o bin/$(GC_JOBS_EXECUTABLE) $(GC_JOBS_MAIN_SRC_FILE)
 
+.PHONY: build-strobe-linux
+build-strobe-linux: ## Build the strobe controller binary for Linux
+	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 $(GO) build -ldflags "$(GO_LDFLAGS)" -o bin/$(STROBE_EXECUTABLE) $(STROBE_MAIN_SRC_FILE)
+
 .PHONY: build-tekton-controller-linux
 build-tekton-controller-linux: ## Build the Tekton controller binary for Linux
 	CGO_ENABLED=0 GOOS=linux GOARCH=amd64 $(GO) build -ldflags "$(GO_LDFLAGS)" -o bin/$(TEKTON_CONTROLLER_EXECUTABLE) $(TEKTON_CONTROLLER_MAIN_SRC_FILE)

charts/lighthouse/templates/_helpers.tpl

@@ -36,6 +36,11 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 {{- printf "%s-%s" .Chart.Name $name | trunc 63 | trimSuffix "-" -}}
 {{- end -}}
 
+{{- define "strobe.name" -}}
+{{- $name := default "strobe" .Values.strobe.nameOverride -}}
+{{- printf "%s-%s" .Chart.Name $name | trunc 63 | trimSuffix "-" -}}
+{{- end -}}
+
 {{- define "tektoncontroller.name" -}}
 {{- $name := default "tekton-controller" .Values.tektoncontroller.nameOverride -}}
 {{- printf "%s-%s" .Chart.Name $name | trunc 63 | trimSuffix "-" -}}

charts/lighthouse/templates/strobe-deployment.yaml

@@ -0,0 +1,53 @@
+{{- if .Values.strobe.enabled }}
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: {{ template "strobe.name" . }}
+  labels:
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
+    app: {{ template "strobe.name" . }}
+spec:
+  replicas: {{ .Values.strobe.replicaCount }}
+  minReadySeconds: 10
+  selector:
+    matchLabels:
+      app: {{ template "strobe.name" . }}
+  template:
+    metadata:
+      labels:
+        app: {{ template "strobe.name" . }}
+{{- if .Values.podAnnotations }}
+      annotations:
+{{ toYaml .Values.podAnnotations | indent 8 }}
+{{- end }}
+    spec:
+      serviceAccountName: {{ template "strobe.name" . }}
+      containers:
+      - name: {{ template "strobe.name" . }}
+        image: {{ tpl .Values.strobe.image.repository . }}:{{ tpl .Values.strobe.image.tag . }}
+        imagePullPolicy: {{ tpl .Values.strobe.image.pullPolicy . }}
+        args:
+          - "--namespace={{ .Release.Namespace }}"
+{{- if hasKey .Values "env" }}
+        env:
+{{- range $pkey, $pval := .Values.env }}
+          - name: {{ $pkey }}
+            value: {{ quote $pval }}
+{{- end }}
+{{- end }}
+        resources:
+{{ toYaml .Values.strobe.resources | indent 10 }}
+      terminationGracePeriodSeconds: {{ .Values.strobe.terminationGracePeriodSeconds }}
+{{- with .Values.strobe.nodeSelector }}
+      nodeSelector:
+{{ toYaml . | indent 8 }}
+{{- end }}
+{{- with .Values.strobe.affinity }}
+      affinity:
+{{ toYaml . | indent 8 }}
+{{- end }}
+{{- with .Values.strobe.tolerations }}
+      tolerations:
+{{ toYaml . | indent 8 }}
+{{- end }}
+{{- end }}

charts/lighthouse/templates/strobe-rb.yaml

@@ -0,0 +1,13 @@
+{{- if .Values.strobe.enabled }}
+kind: RoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: {{ template "strobe.name" . }}
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: {{ template "strobe.name" . }}
+subjects:
+- kind: ServiceAccount
+  name: {{ template "strobe.name" . }}
+{{- end }}

charts/lighthouse/templates/strobe-role.yaml

@@ -0,0 +1,28 @@
+{{- if .Values.strobe.enabled }}
+kind: Role
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: {{ template "strobe.name" . }}
+rules:
+- apiGroups:
+  - ""
+  resources:
+  - configmaps
+  verbs:
+  - get
+  - list
+  - watch
+- apiGroups:
+  - lighthouse.jenkins.io
+  resources:
+  - lighthousejobs
+  verbs:
+  - list
+  - create
+- apiGroups:
+  - lighthouse.jenkins.io
+  resources:
+  - lighthousejobs/status
+  verbs:
+  - update
+{{- end }}

charts/lighthouse/templates/strobe-sa.yaml

@@ -0,0 +1,6 @@
+{{- if .Values.strobe.enabled }}
+kind: ServiceAccount
+apiVersion: v1
+metadata:
+  name: {{ template "strobe.name" . }}
+{{- end }}

charts/lighthouse/values.yaml

@@ -253,6 +253,45 @@ foghorn:
   # foghorn.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the foghorn pods
   tolerations: []
 
+strobe:
+  # strobe.enabled -- Whether to enable the strobe controller
+  enabled: false
+
+  # strobe.replicaCount -- Number of replicas of the strobe controller
+  replicaCount: 1
+
+  image:
+    # strobe.image.repository -- Template for computing the strobe controller docker image repository
+    repository: "{{ .Values.image.parentRepository }}/lighthouse-strobe"
+
+    # strobe.image.tag -- Template for computing the strobe controller docker image tag
+    tag: "{{ .Values.image.tag }}"
+
+    # strobe.image.pullPolicy -- Template for computing the strobe controller docker image pull policy
+    pullPolicy: "{{ .Values.image.pullPolicy }}"
+
+  resources:
+    # strobe.resources.requests -- Resource requests applied to the strobe controller pods
+    requests:
+      cpu: 80m
+      memory: 128Mi
+
+    # strobe.resources.limits -- Resource limits applied to the strobe controller pods
+    limits:
+      cpu: 100m
+      memory: 256Mi
+
+  # strobe.terminationGracePeriodSeconds -- Termination grace period for the strobe controller pods
+  terminationGracePeriodSeconds: 1
+
+  # strobe.nodeSelector -- [Node selector](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector) applied to the strobe controller pods
+  nodeSelector: {}
+
+  # strobe.affinity -- [Affinity rules](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity) applied to the strobe controller pods
+  affinity: {}
+
+  # strobe.tolerations -- [Tolerations](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) applied to the strobe controller pods
+  tolerations: []
 
 tektoncontroller:
   # logLevel -- The logging level: trace, debug, info, warn, error, fatal

cmd/strobe/README.md

@@ -0,0 +1,27 @@
+# Strobe
+
+Strobe is a controller that implements the periodic jobs defined in the
+Lighthouse config ConfigMap:
+
+```yaml
+periodics:
+- name: hello-world
+  cron: "*/1 * * * *"
+  agent: tekton-pipeline
+  pipeline_run_spec:
+    pipelineSpec:
+      tasks:
+      - name: hello-world
+        taskSpec:
+          steps:
+          - image: busybox
+            script: echo 'Hello World!'
+```
+
+This is done by watching the ConfigMap and processing each periodic job by name.
+Inspiration is taken from the [Kubernetes CronJob
+controller](https://github.com/kubernetes/kubernetes/blob/v1.25.2/pkg/controller/cronjob/cronjob_controllerv2.go).
+
+Note that if Strobe misses a schedule time for a particular periodic job due to
+crashing or being restarted it will attempt to schedule a job only for the last
+missed time.