Skip to content

Commit

Permalink
Merge pull request #1636 from jenkins-x/revert-1619-retry_create_pr
Browse files Browse the repository at this point in the history
revert: retry creation of pipelinerun
  • Loading branch information
jenkins-x-bot authored Jan 7, 2025
2 parents 29e2152 + d042b87 commit ff7569c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/engines/tekton/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ func (r *LighthouseJobReconciler) Reconcile(ctx context.Context, req ctrl.Reques

// if pipeline run does not exist, create it
if len(pipelineRunList.Items) == 0 {
if job.Status.State == lighthousev1alpha1.TriggeredState ||
job.Status.State == lighthousev1alpha1.PendingState {
if job.Status.State == lighthousev1alpha1.TriggeredState {
// construct a pipeline run
pipelineRun, err := makePipelineRun(ctx, job, r.namespace, r.logger, r.idGenerator, r.apiReader)
if err != nil {
Expand All @@ -130,6 +129,7 @@ func (r *LighthouseJobReconciler) Reconcile(ctx context.Context, req ctrl.Reques
}
}

// TODO: changing the status should be a consequence of a pipeline run being created
// update status
status := lighthousev1alpha1.LighthouseJobStatus{
State: lighthousev1alpha1.PendingState,
Expand Down

0 comments on commit ff7569c

Please sign in to comment.