Use semantic DeepEqual in foghorn controller

jenkins-x · Jan 8, 2024 · 0855911 · 0855911
1 parent 867b0b5
commit 0855911
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pkg/foghorn/controller.go b/pkg/foghorn/controller.go
@@ -3,7 +3,6 @@ package foghorn
 import (
 	"context"
 	"fmt"
-	"reflect"
 	"strings"
 	"sync"
 	"time"
@@ -18,6 +17,7 @@ import (
 	"github.com/jenkins-x/lighthouse/pkg/watcher"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
+	"k8s.io/apimachinery/pkg/api/equality"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	ctrl "sigs.k8s.io/controller-runtime"
@@ -121,7 +121,7 @@ func (r *LighthouseJobReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	r.updateJobStatusForActivity(activityRecord, jobCopy)
 	r.reportStatus(activityRecord, jobCopy)
 
-	if !reflect.DeepEqual(job.Status, jobCopy.Status) {
+	if !equality.Semantic.DeepEqual(job.Status, jobCopy.Status) {
 		f := func(job *lighthousev1alpha1.LighthouseJob) error {
 			job.Status = jobCopy.Status
 			if err := r.client.Status().Update(ctx, job); err != nil {