Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update docker-compose.yml files for reverse proxy and services #310

Conversation

brett-onions
Copy link
Contributor

@brett-onions brett-onions commented Jun 4, 2024

The docker-compose.yml files for the reverse proxy and services have been updated to include the necessary configurations for the reverse proxy. This will enable routing of requests to the appropriate microfrontend UIs for the fhir-ig-importer, kafka-mapper-consumer, and reprocess-mediator services.

Summary by CodeRabbit

  • New Features

    • Introduced reverse proxy configurations for fhir-ig-importer, kafka-mapper-consumer, and reprocess-mediator services to enhance network routing and security.
    • Added new proxy paths for the mentioned services in both secure and insecure Nginx configuration files.
  • Improvements

    • Updated Docker Compose files to use double quotes for version key consistency.
    • Added new network configurations to support reverse proxy setup.

The docker-compose.yml files for the reverse proxy and services have been updated to include the necessary configurations for the reverse proxy. This will enable routing of requests to the appropriate microfrontend UIs for the fhir-ig-importer, kafka-mapper-consumer, and reprocess-mediator services.
@rcrichton
Copy link
Member

Copy link
Contributor

coderabbitai bot commented Jun 4, 2024

Walkthrough

The recent updates across several docker-compose.yml files primarily involve changing the version declaration from single to double quotes and adding a new service configuration for a reverse-proxy network. Additionally, new proxy configurations have been introduced in Nginx configuration files to route traffic for specific services.

Changes

Files Change Summary
fhir-ig-importer/docker-compose.yml Updated version declaration and added reverse-proxy service configuration.
kafka-mapper-consumer/docker-compose.yml Added reverse-proxy network and external networks under services section.
reprocess-mediator/docker-compose.yml Updated version declaration and added reverse-proxy service configuration.
reverse-proxy-nginx/package-conf-insecure/... Added proxy configurations for /fhir-ig-importer, /kafka-mapper-consumer-ui, and /reprocess-mediator-ui.
reverse-proxy-nginx/package-conf-secure/... Added proxy configurations for /fhir-ig-importer, /kafka-mapper-consumer-ui, and /reprocess-mediator-ui.

Poem

In the code’s deep warren, changes sprout anew,
With networks and proxies, connections to pursue.
Double quotes now shimmer, where single once lay,
Services united, in a more seamless way.
Through Nginx they travel, paths clear and bright,
A rabbit’s delight, in the code’s soft light. 🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@drizzentic drizzentic marked this pull request as ready for review June 5, 2024 13:23
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ec6ae59 and 71e2247.

Files selected for processing (5)
  • fhir-ig-importer/docker-compose.yml (3 hunks)
  • kafka-mapper-consumer/docker-compose.yml (2 hunks)
  • reprocess-mediator/docker-compose.yml (3 hunks)
  • reverse-proxy-nginx/package-conf-insecure/http-openhim-insecure.conf (1 hunks)
  • reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (1 hunks)
Files skipped from review due to trivial changes (2)
  • fhir-ig-importer/docker-compose.yml
  • reprocess-mediator/docker-compose.yml
Additional comments not posted (8)
kafka-mapper-consumer/docker-compose.yml (2)

49-51: Correct configuration of the reverse-proxy network as external. Ensure the external network reverse-proxy_public is correctly set up in your environment.


30-30: LGTM! Ensure the reverse-proxy network is properly configured and tested for connectivity.

reverse-proxy-nginx/package-conf-insecure/http-openhim-insecure.conf (3)

29-33: Configuration for /reprocess-mediator-ui looks good. Verify that the endpoint is reachable and functioning as expected.


23-27: Configuration for /kafka-mapper-consumer-ui looks good. Verify that the endpoint is reachable and functioning as expected.


17-21: Configuration for /fhir-ig-importer looks good. Verify that the endpoint is reachable and functioning as expected.

reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (3)

88-92: Configuration for /fhir-ig-importer looks good. Verify that the endpoint is reachable and functioning as expected.


100-104: Configuration for /reprocess-mediator-ui looks good. Verify that the endpoint is reachable and functioning as expected.


94-98: Configuration for /kafka-mapper-consumer-ui looks good. Verify that the endpoint is reachable and functioning as expected.

@drizzentic drizzentic merged commit d43be85 into main Jun 7, 2024
10 checks passed
@drizzentic drizzentic deleted the CU-86bz23wqj_Expose-Services---fhir-ig-importer-kafka-consumer-mapper-and-reprocess-ui-through-Nginx branch June 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants