-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update docker-compose.yml files for reverse proxy and services #310
feat: Update docker-compose.yml files for reverse proxy and services #310
Conversation
The docker-compose.yml files for the reverse proxy and services have been updated to include the necessary configurations for the reverse proxy. This will enable routing of requests to the appropriate microfrontend UIs for the fhir-ig-importer, kafka-mapper-consumer, and reprocess-mediator services.
WalkthroughThe recent updates across several Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- fhir-ig-importer/docker-compose.yml (3 hunks)
- kafka-mapper-consumer/docker-compose.yml (2 hunks)
- reprocess-mediator/docker-compose.yml (3 hunks)
- reverse-proxy-nginx/package-conf-insecure/http-openhim-insecure.conf (1 hunks)
- reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (1 hunks)
Files skipped from review due to trivial changes (2)
- fhir-ig-importer/docker-compose.yml
- reprocess-mediator/docker-compose.yml
Additional comments not posted (8)
kafka-mapper-consumer/docker-compose.yml (2)
49-51
: Correct configuration of thereverse-proxy
network as external. Ensure the external networkreverse-proxy_public
is correctly set up in your environment.
30-30
: LGTM! Ensure thereverse-proxy
network is properly configured and tested for connectivity.reverse-proxy-nginx/package-conf-insecure/http-openhim-insecure.conf (3)
29-33
: Configuration for/reprocess-mediator-ui
looks good. Verify that the endpoint is reachable and functioning as expected.
23-27
: Configuration for/kafka-mapper-consumer-ui
looks good. Verify that the endpoint is reachable and functioning as expected.
17-21
: Configuration for/fhir-ig-importer
looks good. Verify that the endpoint is reachable and functioning as expected.reverse-proxy-nginx/package-conf-secure/http-openhim-secure.conf (3)
88-92
: Configuration for/fhir-ig-importer
looks good. Verify that the endpoint is reachable and functioning as expected.
100-104
: Configuration for/reprocess-mediator-ui
looks good. Verify that the endpoint is reachable and functioning as expected.
94-98
: Configuration for/kafka-mapper-consumer-ui
looks good. Verify that the endpoint is reachable and functioning as expected.
The docker-compose.yml files for the reverse proxy and services have been updated to include the necessary configurations for the reverse proxy. This will enable routing of requests to the appropriate microfrontend UIs for the fhir-ig-importer, kafka-mapper-consumer, and reprocess-mediator services.
Summary by CodeRabbit
New Features
fhir-ig-importer
,kafka-mapper-consumer
, andreprocess-mediator
services to enhance network routing and security.Improvements