Cu 86bygzkm5 images placement for interoperability proxy identity #289

brett-onions · 2024-04-26T04:13:14Z

Summary by CodeRabbit

New Features
- Introduced environment variables for more dynamic configuration of OpenHIM services.
- Added new environment variables for images, placements, instances, and replicas for various components.
Enhancements
- Updated image references for OpenHIM Console and MongoDB.
- Adjusted CPU and memory limits for better performance.
- Improved Kafka configuration.
Removals
- Removed outdated environment variable related to OpenHIM Console version.

…environment variable

…ta-file-for-interoperability-layer-openhim' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

…ta-file-for-identity-access-manager-keycloak' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

…ta-file-for-openhim-mapping-mediator' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

…ta-file-for-job-scheduler-ofelia' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

rcrichton · 2024-04-26T04:13:18Z

Task linked: CU-86bygzkm5 Images Placement for Interoperability, proxy, identity

drizzentic

LGTM! Resolve the merge conflicts

interoperability-layer-openhim/package-metadata.json

…bility-proxy-identity

BMartinos

@brett-onions overall looks fine to me, just two comments around the existing console env for the image/version to use

interoperability-layer-openhim/docker-compose.yml

interoperability-layer-openhim/package-metadata.json

…bility-proxy-identity

Remove unused files

…bility-proxy-identity

coderabbitai · 2024-05-14T15:45:57Z

Walkthrough

The recent changes across the configuration files bring enhanced flexibility and configurability to the OpenHIM services. By transitioning from static values to environment variables, the deployment process gains dynamism. Moreover, with updated image references and refined service replica settings, resource management and scalability are significantly improved.

Changes

File Path	Change Summary
`interoperability-layer-openhim/docker-compose.yml`	Replaced static values with environment variables for `max_replicas_per_node`, updated image references, and adjusted service replicas.
`interoperability-layer-openhim/package-metadata.json`	Introduced new environment variables for images, placements, instances, and replicas; modified CPU/memory limits; updated Kafka configuration; removed an outdated environment variable.

In the code where changes flow,
Environment variables now in tow,
Images updated, replicas set,
Dynamic setups, the best bet.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2b2aab1 and e422039.

Files selected for processing (13)

identity-access-manager-keycloak/docker-compose.yml (2 hunks)
identity-access-manager-keycloak/package-metadata.json (1 hunks)
interoperability-layer-openhim/docker-compose-mongo.cluster.yml (2 hunks)
interoperability-layer-openhim/docker-compose-mongo.yml (1 hunks)
interoperability-layer-openhim/docker-compose.await-helper-mongo.yml (1 hunks)
interoperability-layer-openhim/docker-compose.await-helper.yml (1 hunks)
interoperability-layer-openhim/docker-compose.yml (3 hunks)
interoperability-layer-openhim/package-metadata.json (2 hunks)
job-scheduler-ofelia/docker-compose.yml (2 hunks)
job-scheduler-ofelia/package-metadata.json (1 hunks)
openhim-mapping-mediator/docker-compose.yml (1 hunks)
openhim-mapping-mediator/package-metadata.json (1 hunks)
test/cucumber/features/single-mode/recipe.feature (1 hunks)

Files skipped from review due to trivial changes (7)

interoperability-layer-openhim/docker-compose-mongo.yml
interoperability-layer-openhim/docker-compose.await-helper-mongo.yml
interoperability-layer-openhim/docker-compose.await-helper.yml
job-scheduler-ofelia/docker-compose.yml
job-scheduler-ofelia/package-metadata.json
openhim-mapping-mediator/docker-compose.yml
test/cucumber/features/single-mode/recipe.feature

Additional comments not posted (10)

openhim-mapping-mediator/package-metadata.json (1)

9-9: Environment variable addition looks good.

interoperability-layer-openhim/docker-compose-mongo.cluster.yml (3)

5-9: Environment variable usage for placement constraints looks good.

12-20: Environment variable usage for image and placement constraints looks good.

35-43: Environment variable usage for image and placement constraints looks good.

interoperability-layer-openhim/package-metadata.json (1)

10-20: Environment variable additions and modifications look good.

identity-access-manager-keycloak/package-metadata.json (1)

9-16: Environment variable additions look good.

identity-access-manager-keycloak/docker-compose.yml (2)

5-11: Environment variable usage for image and command arguments looks good.

47-47: Environment variable usage for placement constraints looks good.

interoperability-layer-openhim/docker-compose.yml (2)

28-28: Environment variable usage for placement constraints looks good.

Line range hint 42-59: Environment variable usage for image and placement constraints looks good.

…y-identity' of github.com:jembi/platform into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

coderabbitai

Actionable comments posted: 0

Out of diff range and nitpick comments (3)

.env.cluster (3)

91-91: Ensure consistency in naming conventions.

Consider using a consistent naming convention for instance variables. For example, JEMPI_WEB_INSTANCES could be renamed to JEMPI_WEB_INSTANCE_COUNT to match the pattern used in other variables.

95-95: Ensure consistency in naming conventions.

Consider using a consistent naming convention for instance variables. For example, JEMPI_REPMGR_PARTNER_NODES could be renamed to JEMPI_REPMGR_PARTNER_NODE_LIST to match the pattern used in other variables.

102-102: Ensure consistency in naming conventions.

Consider using a consistent naming convention for instance variables. For example, JEMPI_API_INSTANCES could be renamed to JEMPI_API_INSTANCE_COUNT to match the pattern used in other variables.

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e422039 and cf9f7a7.

Files selected for processing (2)

.env.cluster (1 hunks)
client-registry-jempi/swarm.sh (1 hunks)

Files skipped from review due to trivial changes (1)

client-registry-jempi/swarm.sh

…bility-proxy-identity

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf9f7a7 and 2c16701.

Files selected for processing (2)

interoperability-layer-openhim/docker-compose.yml (3 hunks)
interoperability-layer-openhim/package-metadata.json (2 hunks)

Files skipped from review as they are similar to previous changes (2)

interoperability-layer-openhim/docker-compose.yml
interoperability-layer-openhim/package-metadata.json

…y-identity' of github.com:jembi/platform into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

coderabbitai

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c16701 and c6539fb.

Files selected for processing (1)

test/cucumber/features/cluster-mode/jempi.cluster.feature (3 hunks)

Additional comments not posted (1)

test/cucumber/features/cluster-mode/jempi.cluster.feature (1)

42-42: Ensure consistency in replica counts.

Please verify that the replica counts for all services are correct and consistent with the intended configuration. For example, openhim-core and openhim-console are set to 3 replicas, while others are set to 1. Ensure this matches the desired setup.

test/cucumber/features/cluster-mode/jempi.cluster.feature

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c6539fb and 98d6e13.

Files selected for processing (1)

test/cucumber/features/cluster-mode/jempi.cluster.feature (3 hunks)

Files skipped from review as they are similar to previous changes (1)

test/cucumber/features/cluster-mode/jempi.cluster.feature

brett-onions added 8 commits April 17, 2024 09:10

Update docker-compose files and package metadata

e6eb5ec

Update Docker Compose files and package metadata

4340b7e

Update job-scheduler-ofelia image and add JOB_SCHEDULER_OFELIA_IMAGE …

6f3de82

…environment variable

Update docker-compose.yml and package-metadata.json

57bf360

Merge branch 'CU-86byc1w20_Make-imageplacement-configurable-in-metada…

1cc4f69

…ta-file-for-interoperability-layer-openhim' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

Merge branch 'CU-86byc1vyx_Make-imageplacement-configurable-in-metada…

f9926e6

…ta-file-for-identity-access-manager-keycloak' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

Merge branch 'CU-86byc1wgy_Make-imageplacement-configurable-in-metada…

a5c5425

…ta-file-for-openhim-mapping-mediator' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

Merge branch 'CU-86byc1w3v_Make-imageplacement-configurable-in-metada…

bf78b83

…ta-file-for-job-scheduler-ofelia' into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

drizzentic approved these changes May 7, 2024

View reviewed changes

drizzentic reviewed May 8, 2024

View reviewed changes

interoperability-layer-openhim/package-metadata.json Outdated Show resolved Hide resolved

brett-onions and others added 2 commits May 8, 2024 12:28

chore: update OPENHIM_CONSOLE_IMAGE to v1.18.2 in package-metadata.json

e4e4780

Merge branch 'main' into CU-86bygzkm5_Images-Placement-for-Interopera…

872b626

…bility-proxy-identity

BMartinos reviewed May 8, 2024

View reviewed changes

interoperability-layer-openhim/docker-compose.yml Show resolved Hide resolved

interoperability-layer-openhim/package-metadata.json Show resolved Hide resolved

responding to comments

072e671

drizzentic marked this pull request as ready for review May 8, 2024 11:36

BMartinos approved these changes May 8, 2024

View reviewed changes

drizzentic and others added 3 commits May 8, 2024 17:30

Merge branch 'main' into CU-86bygzkm5_Images-Placement-for-Interopera…

6bb3cb1

…bility-proxy-identity

fix breaking test

918c7f9

Clean

909cc9e

Remove unused files

bradsawadye marked this pull request as draft May 9, 2024 13:08

bradsawadye marked this pull request as ready for review May 9, 2024 13:08

Merge branch 'main' into CU-86bygzkm5_Images-Placement-for-Interopera…

e422039

…bility-proxy-identity

coderabbitai bot reviewed May 14, 2024

View reviewed changes

bradsawadye added 2 commits May 15, 2024 13:32

Temporarily disable clustered mode for jempi as it is not working

3319148

Merge branch 'CU-86bygzkm5_Images-Placement-for-Interoperability-prox…

cf9f7a7

…y-identity' of github.com:jembi/platform into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

bradsawadye marked this pull request as draft May 15, 2024 11:41

coderabbitai bot reviewed May 15, 2024

View reviewed changes

bradsawadye marked this pull request as ready for review May 15, 2024 11:42

Merge branch 'main' into CU-86bygzkm5_Images-Placement-for-Interopera…

2c16701

…bility-proxy-identity

bradsawadye marked this pull request as draft May 15, 2024 11:46

bradsawadye marked this pull request as ready for review May 15, 2024 11:47

coderabbitai bot reviewed May 15, 2024

View reviewed changes

bradsawadye added 2 commits May 15, 2024 13:52

Jempi only runs in single mode ata the moment

21eacab

Merge branch 'CU-86bygzkm5_Images-Placement-for-Interoperability-prox…

c6539fb

…y-identity' of github.com:jembi/platform into CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity

bradsawadye marked this pull request as draft May 15, 2024 11:53

bradsawadye marked this pull request as ready for review May 15, 2024 11:53

bradsawadye marked this pull request as draft May 15, 2024 12:40

bradsawadye marked this pull request as ready for review May 15, 2024 12:40

coderabbitai bot reviewed May 15, 2024

View reviewed changes

test/cucumber/features/cluster-mode/jempi.cluster.feature Show resolved Hide resolved

Remove repeating of test

98d6e13

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

bradsawadye marked this pull request as draft May 15, 2024 14:15

bradsawadye marked this pull request as ready for review May 15, 2024 14:15

coderabbitai bot reviewed May 15, 2024

View reviewed changes

bradsawadye merged commit 67e1a49 into main May 15, 2024
8 checks passed

bradsawadye deleted the CU-86bygzkm5_Images-Placement-for-Interoperability-proxy-identity branch May 15, 2024 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cu 86bygzkm5 images placement for interoperability proxy identity #289

Cu 86bygzkm5 images placement for interoperability proxy identity #289

brett-onions commented Apr 26, 2024 •

edited by coderabbitai bot

Loading

rcrichton commented Apr 26, 2024

drizzentic left a comment •

edited

Loading

BMartinos left a comment

coderabbitai bot commented May 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

Cu 86bygzkm5 images placement for interoperability proxy identity #289

Cu 86bygzkm5 images placement for interoperability proxy identity #289

Conversation

brett-onions commented Apr 26, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

rcrichton commented Apr 26, 2024

drizzentic left a comment • edited Loading

Choose a reason for hiding this comment

BMartinos left a comment

Choose a reason for hiding this comment

coderabbitai bot commented May 14, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

brett-onions commented Apr 26, 2024 •

edited by coderabbitai bot

Loading

drizzentic left a comment •

edited

Loading

coderabbitai bot commented May 14, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)