Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FHIR IG importer to platform #285

Merged
merged 7 commits into from
May 7, 2024
Merged

Add FHIR IG importer to platform #285

merged 7 commits into from
May 7, 2024

Conversation

drizzentic
Copy link
Collaborator

@drizzentic drizzentic commented Apr 23, 2024 •
edited
Loading

Add FHIR IG Upload mediator and microfrontend UI to platform

@rcrichton
Copy link
Member

Task linked: CU-86byatwb7 Add FHIR IG Upload app to platform

@drizzentic drizzentic force-pushed the CU-86byatwb7_Add-FHIR-IG-Upload-app-to-platform branch from 9417e20 to 93b6561 Compare April 24, 2024 11:11
@drizzentic drizzentic marked this pull request as ready for review April 25, 2024 15:12
@drizzentic drizzentic force-pushed the CU-86byatwb7_Add-FHIR-IG-Upload-app-to-platform branch from fde5f5d to 29a814a Compare April 29, 2024 13:58
bradsawadye
bradsawadye reviewed May 6, 2024
View reviewed changes
config.yaml Outdated Show resolved Hide resolved
@bradsawadye
Copy link
Contributor

@drizzentic looks good. Left some minor comments

BMartinos
BMartinos reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@BMartinos BMartinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, just a couple of comments/questions

fhir-ig-importer/docker-compose.dev.yml Show resolved Hide resolved
fhir-ig-importer/docker-compose.yml Outdated Show resolved Hide resolved
fhir-ig-importer/docker-compose.yml Outdated Show resolved Hide resolved
interoperability-layer-openhim/docker-compose.yml Outdated Show resolved Hide resolved
interoperability-layer-openhim/docker-compose.yml Outdated Show resolved Hide resolved
BMartinos
BMartinos approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@BMartinos BMartinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments, but not blocking the PR from being merged

fhir-ig-importer/package-metadata.json Outdated Show resolved Hide resolved
interoperability-layer-openhim/package-metadata.json Show resolved Hide resolved
@drizzentic drizzentic force-pushed the CU-86byatwb7_Add-FHIR-IG-Upload-app-to-platform branch from 0ca5d92 to 0074f29 Compare May 7, 2024 07:06
@bradsawadye bradsawadye merged commit d618d2f into main May 7, 2024
@bradsawadye bradsawadye deleted the CU-86byatwb7_Add-FHIR-IG-Upload-app-to-platform branch May 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradsawadye bradsawadye bradsawadye approved these changes

@BMartinos BMartinos BMartinos approved these changes

@brett-onions brett-onions Awaiting requested review from brett-onions

@rcrichton rcrichton Awaiting requested review from rcrichton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drizzentic @rcrichton @bradsawadye @BMartinos