Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JeMPI Configuration Update #284

Merged
merged 11 commits into from
Apr 25, 2024
Merged

JeMPI Configuration Update #284

merged 11 commits into from
Apr 25, 2024

Conversation

MatthewErispe
Copy link
Collaborator

Create the latest JeMPI docker images and configure for platform use

This also included updating the openhim mapping configuration

@rcrichton
Copy link
Member

Task linked: CU-86byf2dr7 Update Platform JeMPI Configuration

rcrichton
rcrichton requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@rcrichton rcrichton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. I think you missed changing one endpoint in the mapping mediator though -

platform/client-registry-jempi/importer/mapping-mediator/search.json

Line 48 in 6417513

"url": "http://jempi-api:50000/JeMPI/expanded-golden-record/:patientId",

@MatthewErispe MatthewErispe requested a review from rcrichton April 24, 2024 13:01
@MatthewErispe MatthewErispe marked this pull request as ready for review April 25, 2024 07:00
rcrichton
rcrichton approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

client-registry-jempi/swarm.sh Show resolved Hide resolved
@MatthewErispe MatthewErispe requested a review from BMartinos April 25, 2024 08:13
BMartinos
BMartinos approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@BMartinos BMartinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good to me 👍
Taking note of the changes/enhancements in the mapping mediator forming the new base 👍

@MatthewErispe MatthewErispe merged commit 1da58b0 into main Apr 25, 2024
10 checks passed
@MatthewErispe MatthewErispe deleted the CU-86byf2dr7_Update-Platform-JeMPI-Configuration branch April 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BMartinos BMartinos BMartinos approved these changes

@rcrichton rcrichton rcrichton approved these changes

@bradsawadye bradsawadye Awaiting requested review from bradsawadye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewErispe @rcrichton @BMartinos