-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TB-397 remove jembi superset dependency #269
TB-397 remove jembi superset dependency #269
Conversation
…nnect version instead
…n (and present in config.yaml)
…not shared across)
…remove-jembi-superset-dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arran-standish LGTM
…rset-dependency
dashboard-visualiser-superset/docker-compose.postgres.cluster.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently there exists this repo: https://github.com/jembi/superset which is only used to install a few python dependencies. However, this introduces the overhead of having to keep this custom docker image of superset in sync with apache's superset image. It can also cause some confusion when the latest tag on
jembi/superset:latest
does not correspond toapache/superset:latest
.This PR simply installs said python packages as part of the process of starting the superset image, and as such lets us use
apache/superset
image instead, while retaining the custom python packages we need.Also included in this PR:
./build-image
so that it will use the tag inconfig.yaml
if no tag was passed in but there is a tag present inconfig.yaml