Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TB-397 remove jembi superset dependency #269

Merged
merged 17 commits into from
Mar 19, 2024

Conversation

arran-standish
Copy link
Collaborator

@arran-standish arran-standish commented Feb 23, 2024

Currently there exists this repo: https://github.com/jembi/superset which is only used to install a few python dependencies. However, this introduces the overhead of having to keep this custom docker image of superset in sync with apache's superset image. It can also cause some confusion when the latest tag on jembi/superset:latest does not correspond to apache/superset:latest.

This PR simply installs said python packages as part of the process of starting the superset image, and as such lets us use apache/superset image instead, while retaining the custom python packages we need.
Also included in this PR:

  • Introduce postgresql as the database for superset instead of the default sqlite as per the superset recommendations (https://superset.apache.org/docs/installation/configuring-superset/#using-a-production-metastore)
  • Parameterize the superset FEATURE_FLAGS to more easily allow updates to them and also removes the need to override the package to add/remove flags that platform sets.
  • Add documentation detailing how to go about upgrading + rolling back a superset version upgrade
  • Update ./build-image so that it will use the tag in config.yaml if no tag was passed in but there is a tag present in config.yaml

@arran-standish arran-standish marked this pull request as ready for review February 23, 2024 07:21
MatthewErispe
MatthewErispe previously approved these changes Feb 28, 2024
Copy link
Collaborator

@MatthewErispe MatthewErispe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-image.sh Outdated Show resolved Hide resolved
dashboard-visualiser-superset/docker-compose.postgres.yml Outdated Show resolved Hide resolved
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small comment.

dashboard-visualiser-superset/package-metadata.json Outdated Show resolved Hide resolved
Copy link
Member

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arran-standish arran-standish merged commit f1a2020 into main Mar 19, 2024
2 checks passed
@arran-standish arran-standish deleted the tb-397-remove-jembi-superset-dependency branch March 19, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants