-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tb 181 add mapping for probabilistic patient matching #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will map the jempi patients into fhir format for the match endpoint in jempi TB-181
The candidate threshold can be changed by adding the query parameter "candidateThreshold" to the request. The default value is 0.9 TB-181
The input payload has been changed to a fhir Parameter as required
This enables us to receive errors in fhir format
Use the version with better error handling
…bi/platform into TB-181-add-mapping-for-cr-candidates
The url now has the '$match' in it as expected
bradsawadye
changed the title
Tb 181 add mapping for cr candidates
Tb 181 add mapping for probabilistic patient matching
Oct 26, 2023
MatthewErispe
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradsawadye LGTM
MatthewErispe
approved these changes
Oct 26, 2023
…tails being retrieved from the query
Deterministic endpoint is now a get request
MatthewErispe
approved these changes
Oct 30, 2023
arran-standish
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
When the request comes in via the openhim, the mapping mediator responds in an openhim response format (this is needed for all the details of the transaction to be displayed on the openhim). The logic we had before was returning the response nested in an object with the orchestrations instead of only the response body. This has been changed
MatthewErispe
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds mappings for the cr -candidates match.
Use instructions in readme for testing
Depends on the mapping mediator (version v3.3.0 has to be built to test from jembi/openhim-mediator-mapping#209