Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tb 181 add mapping for probabilistic patient matching #257

Merged
merged 21 commits into from
Oct 31, 2023

Conversation

bradsawadye
Copy link
Contributor

@bradsawadye bradsawadye commented Oct 24, 2023

This adds mappings for the cr -candidates match.

Use instructions in readme for testing

Depends on the mapping mediator (version v3.3.0 has to be built to test from jembi/openhim-mediator-mapping#209

This will map the jempi patients into fhir format for the match endpoint in jempi

TB-181
The candidate threshold can be changed by adding the query parameter "candidateThreshold" to the request. The default value is 0.9

TB-181
@bradsawadye bradsawadye marked this pull request as draft October 24, 2023 09:27
@bradsawadye bradsawadye marked this pull request as ready for review October 24, 2023 09:28
The input payload has been changed to a fhir Parameter as required
This enables us to receive errors in fhir format
Use the version with better error handling
…bi/platform into TB-181-add-mapping-for-cr-candidates
The url now has the '$match' in it as expected
@bradsawadye bradsawadye changed the title Tb 181 add mapping for cr candidates Tb 181 add mapping for probabilistic patient matching Oct 26, 2023
Copy link
Collaborator

@MatthewErispe MatthewErispe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic endpoint is now a get request
Copy link
Collaborator

@arran-standish arran-standish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

When the request comes in via the openhim, the mapping mediator responds in an openhim response format (this is needed for all the details of the transaction to be displayed on the openhim). The logic we had before was returning the response nested in an object with the orchestrations instead of only the response body. This has been changed
@bradsawadye bradsawadye marked this pull request as draft October 31, 2023 06:25
@bradsawadye bradsawadye marked this pull request as ready for review October 31, 2023 06:25
@bradsawadye bradsawadye merged commit d92ff9a into main Oct 31, 2023
8 checks passed
@bradsawadye bradsawadye deleted the TB-181-add-mapping-for-cr-candidates branch October 31, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants