Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-620 Add JeMPI services #179

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Conversation

Mark-Labuschagne
Copy link
Contributor

@Mark-Labuschagne Mark-Labuschagne commented Nov 24, 2022

The CI will only pass once the Dockerhub repos are made (request in progress) and the images are pushed. And the below requirements are filled.

Reasoning: the CI must pull private images, and those images can only be pulled if the docker login issue is sorted in openhie/package-starter-kit and the related PRs.

these services, for now, can be deployed at the same time, so there is
not reason for them to be seperated
PLAT-620
some commands were being done repetitively, so they are no done in a
loop
PLAT-620
there are possible errors that can arise form launching the alphas
before the zero is up, so the zero is launched in a seperated compose
file
PLAT-620
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 24, 2022 11:26
Copy link
Contributor

@marrouchi marrouchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work ! Left one comment

client-registry-jempi/package-metadata.json Outdated Show resolved Hide resolved
@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft November 24, 2022 12:08
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 24, 2022 13:46
Copy link
Collaborator

@nour-borgi nour-borgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft November 28, 2022 09:28
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 28, 2022 09:28
@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft November 28, 2022 19:24
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review November 28, 2022 19:24
@Mark-Labuschagne Mark-Labuschagne merged commit 62e8a52 into main Nov 29, 2022
@Mark-Labuschagne Mark-Labuschagne deleted the PLAT-620-add-jempi-services branch November 29, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants