Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware Selection Guide Cleanup #963

Merged
merged 14 commits into from
Jul 23, 2024

Conversation

felix920506
Copy link
Member

** Please do NOT merge until after 10.9 **

Cleaning up the hardware selection page and general updating.

@felix920506 felix920506 added documentation Improvements or additions to documentation cleanup Cleanup of legacy code or code smells future-release Documentation change for a future Jellyfin release labels Apr 20, 2024
Copy link
Member

@gnattu gnattu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments that I think is not quite accurate.

It's very risky to provide power consumption numbers, as the comparison needs to be conducted in a highly controlled lab environment to make any sense, especially for loaded power consumption. This figure will vary significantly depending on the workload and user configuration. Detailed lab testing is really out of the scope of this document.

docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
docs/general/administration/hardware-selection.md Outdated Show resolved Hide resolved
@felix920506 felix920506 requested a review from gnattu April 22, 2024 04:48
@felix920506 felix920506 requested a review from gnattu April 25, 2024 22:39
@felix920506 felix920506 requested a review from gnattu April 30, 2024 20:39
@nielsvanvelzen nielsvanvelzen removed the future-release Documentation change for a future Jellyfin release label Jul 23, 2024
@felix920506 felix920506 requested a review from JPVenson July 23, 2024 07:18
@felix920506 felix920506 merged commit 24bc9e8 into jellyfin:master Jul 23, 2024
7 checks passed
@felix920506 felix920506 deleted the hwsel-cleanup branch July 23, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants