Docs: Installing on TrueNAS #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds sidebar_position value, should fix failing build test
felix920506
reviewed
Dec 18, 2023
Co-authored-by: felix920506 <[email protected]>
|
ty for the suggestions @felix920506! Might take me a few weeks to circle back to this, but I will be reworking to address them |
felix920506
reviewed
Jan 20, 2024
felix920506
requested changes
Jan 20, 2024
There was a problem hiding this comment.
Reading through this guide, I find quite a bit of duplicate information on the bottom. I don't know if this is intended or not. However, I find the info on the bottom more useful when trying to configure the App compared to their counterparts on the top.
There are also a few things, please check my comments in the middle.
DjP-iX
commented
Jan 22, 2024
DjP-iX
commented
Jan 22, 2024
Committing basic suggestions now, will work on collapsing the top and bottom sections in a separate commit Co-authored-by: felix920506 <[email protected]>
|
@DjP-iX is this ready for re-review? |
|
I haven't looked at it in some time, but as far as I know it is |
Gauvino
suggested changes
Jul 23, 2024
Co-authored-by: Gauvino <[email protected]>
Co-authored-by: Gauvino <[email protected]>
|
Superseded by #1228 and credited as coauthor in merge commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces documentation on installing the Jellyfin application in TrueNAS SCALE.
Note: I've left the
sidebar_positionundefined to allow you to weight as needed.