Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manet to the clients list #1172

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

bzf
Copy link
Contributor

@bzf bzf commented Oct 27, 2024

First of all - thank you all for your hard work on Jellyfin! It really is a great piece of software 🙌🏽

I'm the developer of the Manet music app for iOS and got sent a link to this form post that suggests that you might accept paid apps for the jellyfin.org website, so I thought I'd send this PR to open the discussion about being added.

@nielsvanvelzen nielsvanvelzen self-requested a review October 27, 2024 13:20
@JPVenson JPVenson self-requested a review October 27, 2024 13:24
@JPVenson
Copy link
Member

Hey there,
Thank you for creating this app, however i need to ask you if you would be willing to publish the sourcecode in an FOSS compatible licence as your list of requirements sets this as an important point.

https://jellyfin.org/docs/general/clients/#requirements-for-inclusion-in-all-clients

@bzf
Copy link
Contributor Author

bzf commented Oct 27, 2024

@JPVenson Ah, I missed that point! I was reading on the Recommended clients requirements and missed that point. I don't intend on moving the app into a FOSS license for the time being, I guess I'll close this PR then.

Sorry for not reading it through properly 🙈

@bzf bzf closed this Oct 27, 2024
@bzf bzf deleted the add-manet-as-a-client branch October 27, 2024 13:55
@JPVenson
Copy link
Member

Thats sad, we can still discuss internally if the app warents an exclusion from that rule because there are some points we might consider if you want to keep the request up.

@bzf bzf restored the add-manet-as-a-client branch October 27, 2024 14:04
@bzf
Copy link
Contributor Author

bzf commented Oct 27, 2024

Sure thing, I'd be happy to be listed on the website if possible. I can re-open it and I'll leave it to you to decide to merge or close it later on then 😊

@bzf bzf reopened this Oct 27, 2024
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 2382bad321016decaddf13ffb5e9a88ddd92fc16
Status ✅ Deployed!
Preview URL https://51cc3dad.jellyfin-org.pages.dev
Type 🔀 Preview

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with core team and we'd be happy to include Manet in our listing!

@nielsvanvelzen nielsvanvelzen merged commit 2c8a2bb into jellyfin:master Oct 27, 2024
11 checks passed
@bzf bzf deleted the add-manet-as-a-client branch October 27, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants