Add Jellychord to clients list #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
nielsvanvelzen
requested changes
Oct 12, 2024
| @@ -719,6 +719,22 @@ export const Clients: Array<Client> = [ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
New additions should be added to the bottom of the list
There was a problem hiding this comment.
I was told by @thornbill that the place I put it is the appropriate position
https://matrix.to/#/!IcxAyGVzujeflEJlQt%3Amatrix.org/%24fUT6f4R2bsFnhzn8tqA7noXkGCo4PV4oYBxSPL-DR8E
There was a problem hiding this comment.
I think I agree will @thornbill's ordering.
There was a problem hiding this comment.
Yep should be fine considering it was already discussed 👍
nielsvanvelzen
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Jellychord to clients list