Fix some typography #1138
Fix some typography #1138
Conversation
There was a problem hiding this comment.
So, for these files I need the help of the whole jellyfin team to make a proper source tree, I tried my best for something but for the rest I don't really each project and maybe listing all of the other projects would be great !
Cloudflare Pages deployment
|
| @@ -9,7 +9,7 @@ title: Jellyfin Web Configuration | |||
|
|
|||
| The Jellyfin Web default interface can be configured using the `config.json` file in the webroot. Where this is and how to edit it depends on the installation method. | |||
|
|
|||
| We recommend obtaining the [stable](https://github.com/jellyfin/jellyfin-web/blob/release-10.8.z/src/config.json) or the [unstable](https://github.com/jellyfin/jellyfin-web/blob/master/src/config.json) default version of the file to pre-populate your configuration directory before starting Jellyfin for the first time; unlike most other components of this directory, it will not be created automatically. | |||
| We recommend obtaining the [stable](https://github.com/jellyfin/jellyfin-web/blob/release-10.8.z/src/config.json) or the [unstable](https://github.com/jellyfin/jellyfin-web/blob/master/src/config.json) default version of the file to pre-populate your configuration directory before starting Jellyfin for the first time; Unlike most other components of this directory, it will not be created automatically. | |||
There was a problem hiding this comment.
you don't need to capitalize after semicolon
There was a problem hiding this comment.
Do I need to make this on every semicolon I did change ?
|
First, this is a massive PR and I'm not in favour of a massive single change like this, for the reasons below. Second, there's some changes in here that are good, and some that make no sense or are outright wrong. But because it's so large, commenting on each one would be a massive burden on us. Third, it looks like you just ran the entire docs repo through a spellchecker. As a first step that's fine, but committing the results blindly is not good form. Please split this into multiple smaller PRs targeting specific areas first, and ensure each one is well-proofread before submitting. We can then take each individual change individually for comment as required. |
No problem I totally understand this point.
Yes I did use a spell check, and use my English also to make the best, but I'm not that good so I did my best.
Right now I can't do this I don't have any time left, but when I got some I'll do everything I could, yes! |
Thanks you for taking time to make a proper review on my PR ! |
Hello, tried my best to fix all of the typography I could to have a clear documentation of Jellyfin.
I need some help on different change because I don't have the capacity to make the proper change for some things and will comment on every line I need help in.
I could make some error, so please be gentle and tell me why, thanks in advance.
This PR will probably make some conflict with most of the other PR is merged before, so feel free to merge it when you want!