Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients/vue): create deployment documentation #1110

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

ferferga
Copy link
Member

I thought of a necessary security disclaimer while redacting the docs, and they were also applicable to the testing instructions added in #1104

docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
Copy link
Member

@felix920506 felix920506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have instructions on setting a default JF server for vue? As in it will automatically prompt me to login to a specified instance instead of asking me for a server address.

@ferferga
Copy link
Member Author

ferferga commented Sep 11, 2024

@felix920506 This is already specified in the environment variables section (see the complete reference link)

Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix

docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
@ferferga
Copy link
Member Author

@Gauvino Thank you very much for your feedback!

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all the back-links to the docker-compose file needed?

docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Show resolved Hide resolved
docs/general/clients/jellyfin-vue.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
ferferga and others added 5 commits September 12, 2024 02:19
The hashtag at the beginning makes possible that Docusaurus still renders the page's title, rendering the rest of the headers at h2< size,
which is needed to keep a better distinction between the different sections

Signed-off-by: GitHub <[email protected]>
Co-authored-by: Niels van Velzen <[email protected]>
Co-authored-by: Gauvino <[email protected]>
Co-authored-by: Odd Stråbø <[email protected]>
@ferferga ferferga enabled auto-merge September 12, 2024 00:20
@ferferga ferferga merged commit 155b57b into jellyfin:master Sep 12, 2024
8 checks passed
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 49ea0e3516dbe4af5f8982896448f7a8de1c993c
Status ✅ Deployed!
Preview URL https://98504017.jellyfin-org.pages.dev
Type 🔀 Preview

@ferferga ferferga deleted the vue-deployment branch September 12, 2024 00:24
ferferga added a commit to jellyfin/jellyfin-vue that referenced this pull request Sep 12, 2024
The new deployment documentation has been pushed
to the main Jellyfin documentation:
jellyfin/jellyfin.org#1110

The wiki has also been updated to reflect those changes:
https://github.com/jellyfin/jellyfin-vue/wiki/Deployment/81af939a4773c985cf5b64a33436200bee0f12f1

The last required piece was the repository's README

Signed-off-by: Fernando Fernández <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants