Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testing web clients from code #1109

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

felix920506
Copy link
Member

No description provided.

docs/general/testing/web/index.md Outdated Show resolved Hide resolved
@felix920506
Copy link
Member Author

I don't know if the added instructions should be on their own page or in the same page as testing from the cloudflare pages deployments

@ferferga
Copy link
Member

Vue has also their own docs for development, maybe a good idea to link them in this section: https://github.com/jellyfin/jellyfin-vue/wiki/Contributing#development-setup

@felix920506 felix920506 marked this pull request as ready for review September 10, 2024 19:41
@felix920506 felix920506 changed the title add testing from code add testing web clients from code Sep 10, 2024
Copy link
Contributor

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix

docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@felix920506 felix920506 force-pushed the testing-web-from-master-cont branch from 18a37b5 to f152a1b Compare September 12, 2024 02:54
@felix920506
Copy link
Member Author

dealing with merge conflicts

docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
docs/general/testing/web/index.md Outdated Show resolved Hide resolved
Co-authored-by: Bill Thornton <[email protected]>
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 5e3905681c084eb6374e8bb44be33733f9be7aed
Status ✅ Deployed!
Preview URL https://090eeafa.jellyfin-org.pages.dev
Type 🔀 Preview

@felix920506 felix920506 merged commit 7536829 into jellyfin:master Sep 17, 2024
8 checks passed
@felix920506 felix920506 deleted the testing-web-from-master-cont branch September 17, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants