Add dedicated dotnet tab for dotnet portable build #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are listing these portable builds under all OS tabs, which may confuse users because each OS also has its own platform-specific builds that we refer to as “portable” in our documentation. To avoid confusion, separate the tabs accordingly.
gnattu
force-pushed
the
dedicated-dotnet-portable
branch
from
8746bde to
0269cf5
Compare
gnattu
changed the title
src/data/downloads.tsx
Outdated
| status: DownloadStatus.Official, | ||
| features: [], | ||
| platforms: [Platform.DotNet], | ||
| description: 'The portable version can be run on any system with a .NET Core runtime.', | ||
| description: 'The portable version can be run on any system with a .NET runtime.', |
There was a problem hiding this comment.
Good idea, though I think it should be even more explicit:
+description: 'The .NET portable version can be run on any system with a .NET runtime using dotnet jellyfin.dll.',
There was a problem hiding this comment.
Well it seems like we cannot use markdown in this description, I change this to 'The .NET portable version can be run on any system with a .NET runtime using jellyfin.dll', which also explicitly states the user has to use the dll directly for this version.
joshuaboniface
approved these changes
Aug 23, 2024
JPVenson
approved these changes
Aug 31, 2024
felix920506
reviewed
Aug 31, 2024
felix920506
reviewed
Aug 31, 2024
Cloudflare Pages deployment
|
felix920506
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are listing these portable builds under all OS tabs, which may confuse users because each OS also has its own platform-specific builds that we refer to as “portable” in our documentation. To avoid confusion, separate the tabs accordingly.
This also updated the description as the .NET Core runtime is now just .NET runtime