Add new lyrics page #1054
Closed
Add new lyrics page #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a description. |
|
Why did you close the original pull request with a pending review... |
Gauvino
suggested changes
Jul 23, 2024
| ``` | ||
|
|
||
| ### Unsynchronized | ||
| Unlike syncronized lyrics, unsyncronized lyrics are easier to implament, but will be harder for users to sing along. |
There was a problem hiding this comment.
Suggested change
| Unlike syncronized lyrics, unsyncronized lyrics are easier to implament, but will be harder for users to sing along. | |
| Unlike synchronized lyrics, unsynchronized lyrics are easier to implement, but will be harder for users to sing along. |
|
@JustJamie4realz has this been abandoned? Happy to open a new one if needs be |
|
@M-Davies just open a new PR please |
M-Davies
added a commit
to M-Davies/jellyfin.org
that referenced
this pull request
Sep 25, 2024
* Inspired by @JustJamie4realz work -> jellyfin#1054 Signed-off-by: Morgan Davies <[email protected]>
|
Closing in favor of #1133 since this thread looks abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.