Changing default reverse proxy config to work locally #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, i think most users run jellyfin on the same local server as they run their reverse nginx proxy, so it seems logical that the nginx config files are set this way by default instead of using the dns resolve mechanism as it currently does, so i'm proposing this small change to reflect this. It should allow people to get their reverse proxy working more easily and less troubleshooting questions about it.
|
Please provide a title more descriptive of the changes made. |
NeutroGe
changed the title
done! |
felix920506
requested changes
Aug 23, 2024
joshuaboniface
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
I like the change and agree with the idea but second @felix920506's comment about suggesting people change this to something else if needed.
Cloudflare Pages deployment
|
|
So much nonsense for such a small change, last time i try to help here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i think most users run jellyfin on the same local server as they run their reverse nginx proxy, so it seems logical that the nginx config files are set this way by default instead of using the dns resolve mechanism as it currently does, so i'm proposing this small change to reflect this. It should allow people to get their reverse proxy working more easily and less troubleshooting questions about it.