Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate VAProfile to Jellyfin Setting #1008

Merged
merged 1 commit into from
Jun 9, 2024
Merged

translate VAProfile to Jellyfin Setting #1008

merged 1 commit into from
Jun 9, 2024

Conversation

jumoog
Copy link
Contributor

@jumoog jumoog commented May 25, 2024

it is not clear what each VAProfile means

Just parsing the vainfo output and setting up the correct settings might be easier.

@felix920506
Copy link
Member

please fix the linter issues.

@gnattu
Copy link
Member

gnattu commented Jun 8, 2024

LGTM in general, but I prefer the table like this:

Jellyfin Setting VA-API Profil
H264 VAProfileH264Baseline
VAProfileH264Main
VAProfileH264High
VAProfileH264ConstrainedBaseline
HEVC VAProfileHEVCMain
MPEG2 VAProfileMPEG2Simple
VAProfileMPEG2Main
VC1 VAProfileVC1Simple
VAProfileVC1Main
VAProfileVC1Advanced
VP8 VAProfileVP8Version0
VAProfileVP8Version1
VAProfileVP8Version2
VAProfileVP8Version3
VP9 VAProfileVP9Profile0
AV1 VAProfileAV1Profile0
HEVC 10bit VAProfileHEVCMain10
VP9 10bit VAProfileVP9Profile2
| Jellyfin Setting | VA-API Profil                                                                                         |
|------------------|-------------------------------------------------------------------------------------------------------|
| H264             | VAProfileH264Baseline<br>VAProfileH264Main<br>VAProfileH264High<br>VAProfileH264ConstrainedBaseline   |
| HEVC             | VAProfileHEVCMain                                                                                     |
| MPEG2            | VAProfileMPEG2Simple<br>VAProfileMPEG2Main                                                            |
| VC1              | VAProfileVC1Simple<br>VAProfileVC1Main<br>VAProfileVC1Advanced                                        |
| VP8              | VAProfileVP8Version0<br>VAProfileVP8Version1<br>VAProfileVP8Version2<br>VAProfileVP8Version3          |
| VP9              | VAProfileVP9Profile0                                                                                  |
| AV1              | VAProfileAV1Profile0                                                                                  |
| HEVC 10bit       | VAProfileHEVCMain10                                                                                   |
| VP9 10bit        | VAProfileVP9Profile2                                                                                  |

@jumoog
Copy link
Contributor Author

jumoog commented Jun 8, 2024

LGTM in general, but I prefer the table like this:
Jellyfin Setting VA-API Profil
H264 VAProfileH264Baseline
VAProfileH264Main
VAProfileH264High
VAProfileH264ConstrainedBaseline
HEVC VAProfileHEVCMain
MPEG2 VAProfileMPEG2Simple
VAProfileMPEG2Main
VC1 VAProfileVC1Simple
VAProfileVC1Main
VAProfileVC1Advanced
VP8 VAProfileVP8Version0
VAProfileVP8Version1
VAProfileVP8Version2
VAProfileVP8Version3
VP9 VAProfileVP9Profile0
AV1 VAProfileAV1Profile0
HEVC 10bit VAProfileHEVCMain10
VP9 10bit VAProfileVP9Profile2

| Jellyfin Setting | VA-API Profil                                                                                         |
|------------------|-------------------------------------------------------------------------------------------------------|
| H264             | VAProfileH264Baseline<br>VAProfileH264Main<br>VAProfileH264High<br>VAProfileH264ConstrainedBaseline   |
| HEVC             | VAProfileHEVCMain                                                                                     |
| MPEG2            | VAProfileMPEG2Simple<br>VAProfileMPEG2Main                                                            |
| VC1              | VAProfileVC1Simple<br>VAProfileVC1Main<br>VAProfileVC1Advanced                                        |
| VP8              | VAProfileVP8Version0<br>VAProfileVP8Version1<br>VAProfileVP8Version2<br>VAProfileVP8Version3          |
| VP9              | VAProfileVP9Profile0                                                                                  |
| AV1              | VAProfileAV1Profile0                                                                                  |
| HEVC 10bit       | VAProfileHEVCMain10                                                                                   |
| VP9 10bit        | VAProfileVP9Profile2                                                                                  |

Yes looks better this way

@gnattu
Copy link
Member

gnattu commented Jun 9, 2024

Sorry, our CI wants the newline tag to be a closing tag <br/> instead of <br>. Can you update that?

it is not clear what each VAProfile means
@nielsvanvelzen nielsvanvelzen merged commit b43b226 into jellyfin:master Jun 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants