Fix for upcoming 10.9 release #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are using dotnet 8 which requires macOS 12, targetting an earlier version is not useful. This will enable us to use new APIs in the future.
We should use the cmd line to specify ffmpeg path. This will make it impossible to let user specify custom ffmpeg now. If that is a supported use case, we need to implement it in the preference panel.
anthonylavado
approved these changes
Mar 28, 2024
|
It all looks good to me. As for ffmpeg, I feel like people might have used the homebrew one in the past. Now that we're bundling our own with significant improvements, I don't anticipate it being an issue. If it is, we'll cross that bridge when we come to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
--ffmpegCLI parameter. This would make it impossible for our users to specify a custom ffmpeg binary, and if that is a supported use case, then an additional setting for this in this app is required.