Enable OSD for intro videos #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
added
the
general-improvement
|
The only possible problems I can think of would be certain parts of the OSD not working or maybe even crashing because the intro video metadata is different than a regular video. We'll need to test things like the chapter selection menu (do intro videos even have chapters?), audio track selection, subtitle selection, etc. I'll give this a test when I get a chance. Thanks for the PR. |
|
I tried testing this yesterday but I've never used intro videos before and ran into some trouble getting them to play at all. I'll review this once I get everything set up 😅 |
|
No worries. I barely knew about Intro Videos either. I was just trying out the feature and wanted it to work differently. |
cewert
approved these changes
Nov 26, 2024
cewert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed checks that turned off OSD, trickplay and captions for Intro Videos.