-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transcode multichannel audio to keep multichannel support #2003
base: 2.2.z
Are you sure you want to change the base?
Conversation
9a4ac22
to
c0f0a18
Compare
Posted a testing comment here #1979 (comment) |
@dathbe thanks for testing. Can you post the file info? Either ffprobe or the media info from the web client. Does it create a transcode log for the server? If so can you post that too |
I tried three files. One I had created for testing purposes with 5.1 AAC, and the other two were just standard files already on my HDD. Here are the stats for the new file.
I do not see any transcode logs. The existing files on my HDD should have direct played without any transcoding. Also, flagging that @closesim tested and replied here: #1979 (comment) I'll also add that I tested both the new and existing files in the production version of the app, and they all played fine (with the expected downmixing of AAC 5.1 to 2.0). |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
If the device supports multichannel audio and the selected audio stream has more than 2 channels, tell the server we want
ac3
(or dts) instead of the usual aac for stereo speakers.Issues
Remake of #1466
Fixes #1979