Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on episode list #1951

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 1, 2024

Validate data from api to prevent crash on episode list

Comes from roku.com crash log:

info             <uninitialized> 
trackselected    <uninitialized> 
panel            <uninitialized> 
button           <uninitialized> 
movie            <uninitialized> 
trailerdata      <uninitialized> 
buttons          <uninitialized> 
btn              <uninitialized> 
startingpoint    <uninitialized> 
results          <uninitialized> 
options          <uninitialized> 
query            <uninitialized> 
viewhandled      <uninitialized> 
screencontent    <uninitialized> 
selectedindex    <uninitialized> 
albums           <uninitialized> 
series           roSGNode:TVShowDetails refcnt=1 
ptr              roArray refcnt=1 count:2 
node             roSGNode:TVSeasonData refcnt=1 
photoplayer      <uninitialized> 
photoalbumdata   <uninitialized> 
showplaybackoptiondialog <uninitialized> 
audio_stream_idx Integer val:0 (&h0) 
selecteditemtype roString refcnt=1 val:"Episode" 
selecteditem     roInvalid refcnt=1 
popupnode        <uninitialized> 
inputeventvideo  <uninitialized> 
posttask         <uninitialized> 
tmpglobaldevice  <uninitialized> 
event            roAssociativeArray refcnt=1 count:2 
retryvideo       <uninitialized> 
video            <uninitialized> 
moviemetadata    <uninitialized> 
seasonmetadata   <uninitialized> 
i                Integer val:21 (&h15) 
currentepisode   roAssociativeArray refcnt=1 count:31 
currentscene     roSGNode:TVEpisodes refcnt=1 
elapsed          <uninitialized> 
itemtype         <uninitialized> 
reportingnodetype <uninitialized> 
itemnode         <uninitialized> 
reportingnode    <uninitialized> 
timespan         <uninitialized> 
msg              roSGNodeEvent refcnt=1 
deeplinkvideo    <uninitialized> 
device           roDeviceInfo refcnt=1 
input            roInput refcnt=1 
dialog           <uninitialized> 
userslastrunversion roString refcnt=1 val:"2.1.4" 
filename         <uninitialized> 
re               <uninitialized> 
configencoding   roAssociativeArray refcnt=1 count:43 
group            roSGNode:TVEpisodes refcnt=1 
scenemanager     roSGNode:SceneManager refcnt=1 
playstatetask    roSGNode:PlaystateTask refcnt=1 
m                roAssociativeArray refcnt=2 count:6 
global           Interface:ifGloba$1 args             roAssociativeArray refcnt=2 count:4 
Local Variables: 
   file/line: pkg:/source/Main.brs(215) 
#0  Function main(args As Dynamic) As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/source/Main.brs(215)

which points to this line after running build-prod on 2.1.4:

m.global.queueManager.callFunc("setTopStartingPoint", currentScene.objects.Items[i].json.UserData.PlaybackPositionTicks)

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Oct 1, 2024
@cewert cewert requested a review from a team as a code owner October 1, 2024 15:26
@cewert cewert merged commit 3e6d062 into jellyfin:2.1.z Oct 2, 2024
13 checks passed
@cewert cewert deleted the fix-episode-list-crash branch October 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants