Save global refs to prevent deep copies #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
added
the
general-improvement
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
jellyfin-bot
added
merge-conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
jimdogx
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should speed things up a bit for the views being updated, especially on slower devices.
ItemGridand theAudioPlayerViewhad lots of changesChanges
m.globalto a local var when they are used more than once. Except for the global constants since the AA is so small