Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MovieDetails crash (2) #1865

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 25, 2024

Validate criticRatingIcon node exists before using to prevent crash. This comes from the roku crash log.

Crashlog:


Invalid value for left-side of expression. (runtime error &he4) in pkg:/components/movies/MovieDetails.brs(127) 
Backtrace: 
#0  Function itemcontentchanged() As Voi$1 file/line: pkg:/components/movies/MovieDetails.brs(128) 
Local Variables: 
global           Interface:ifGloba$1 m                roAssociativeArray refcnt=2 count:14 
item             roSGNode:MovieData refcnt=1 
itemdata         roAssociativeArray refcnt=1 count:53 
tomato           String (VT_STR_CONST) val:"pkg:/images/fresh.png" 
directors        <uninitialized> 
person           <uninitialized> 
airdate          <uninitialized>

which points to this line after running build-prod on 2.1.2:

m.top.findNode("criticRatingIcon").uri = tomato

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 25, 2024
@cewert cewert requested a review from a team as a code owner July 25, 2024 03:37
@cewert cewert merged commit d1a2d11 into jellyfin:2.1.z Jul 28, 2024
13 checks passed
@cewert cewert deleted the fix-moviedetails-crash2 branch July 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants