Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MovieDetails crash #1864

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Fix MovieDetails crash #1864

merged 3 commits into from
Jul 28, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 25, 2024

Validate item.json before using to prevent crash. This comes from the roku crash log.

Crashlog:


'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/movies/MovieDetails.brs(97) 
Backtrace: 
#0  Function itemcontentchanged() As Voi$1 file/line: pkg:/components/movies/MovieDetails.brs(97) 
Local Variables: 
global           Interface:ifGloba$1 m                roAssociativeArray refcnt=2 count:14 
item             roSGNode:MovieData refcnt=1 
itemdata         Invali$1 tomato           <uninitialized> 
directors        <uninitialized> 
person           <uninitialized> 
airdate          <uninitialized>

which points to this line after running build-prod on 2.1.2:

m.top.id = itemData.id

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 25, 2024
@cewert cewert requested a review from a team as a code owner July 25, 2024 03:21
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Jul 28, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Jul 28, 2024
@cewert cewert merged commit 0539e1b into jellyfin:2.1.z Jul 28, 2024
11 checks passed
@cewert cewert deleted the fix-moviedetails-crash branch July 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants