-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add View All for Next Up #1846
Add View All for Next Up #1846
Conversation
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option menu opens as expected on the new View All Next Up page but there are no options to choose from. Maybe we should disable the options button for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Episodes without a widescreen image are in the shape of the folder icon when viewing the View All Next Up view. I sent you a screenshot on matrix
Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄 |
Home page uses |
Took me all day to figure this one out... turns out it was the frigging "PosterMask" that was causing the clipping. |
@cewert it occurred to me that making it smarter wouldn't be that hard after all. Plus I coded it so that it's an extra API call if (and only if) there really isn't anything to show in the Next Up home row. 👍 Ready for review again 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well with no crashes 👍
Some observations:
- The episode posters are still using
slaceToFit
instead ofscaleToZoom
like the home page. - The View All button color is randomly grabbed every time the page is refreshed.
Thank you for working on this. Will make using Roku app better with my Parkinsons. I won't have to go hunt for episodes that dropped off the list. I've been hoping for this for a long time! #1481 (comment) |
Add "View All Next Up".
Changes
Adds a new "View All Next Up" on the Next Up home screen row. This adds parity to the web client and allows the user to see items that are Next Up that don't fit within the Roku's max column count or items that might be greater than 365 days old.
Issues
Fixes #1481