Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add View All for Next Up #1846

Merged
merged 8 commits into from
Jul 29, 2024
Merged

Add View All for Next Up #1846

merged 8 commits into from
Jul 29, 2024

Conversation

jimdogx
Copy link
Contributor

@jimdogx jimdogx commented Jul 21, 2024

Add "View All Next Up".

Changes

Adds a new "View All Next Up" on the Next Up home screen row. This adds parity to the web client and allows the user to see items that are Next Up that don't fit within the Roku's max column count or items that might be greater than 365 days old.

Issues

Fixes #1481

@jimdogx jimdogx requested a review from a team as a code owner July 21, 2024 04:43
@jimdogx jimdogx marked this pull request as draft July 21, 2024 12:33
@jimdogx jimdogx marked this pull request as ready for review July 21, 2024 12:41
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Jul 21, 2024
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Jul 21, 2024
@cewert cewert added the feature A new feature that currently doesn't exist. label Jul 23, 2024
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Home page crashed with one of my test users. datum.CollectionType was invalid

roku1481-crash

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option menu opens as expected on the new View All Next Up page but there are no options to choose from. Maybe we should disable the options button for now?

@jimdogx jimdogx requested a review from cewert July 25, 2024 00:41
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Episodes without a widescreen image are in the shape of the folder icon when viewing the View All Next Up view. I sent you a screenshot on matrix

@jimdogx
Copy link
Contributor Author

jimdogx commented Jul 25, 2024

Episodes without a widescreen image are in the shape of the folder icon when viewing the View All Next Up view. I sent you a screenshot on matrix

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

@cewert
Copy link
Member

cewert commented Jul 25, 2024

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

Home page uses scaleToZoom for the Poster node's loadDisplayMode property. https://developer.roku.com/en-ca/docs/references/scenegraph/renderable-nodes/poster.md#fields

@jimdogx
Copy link
Contributor Author

jimdogx commented Jul 27, 2024

Do you know off the top of your head what the home screen does in this case? I was trying to make the "View All" page work exactly like the "Next Up" row on the home screen. And on my setup, they are all wide screen posters 😄

Home page uses scaleToZoom for the Poster node's loadDisplayMode property. https://developer.roku.com/en-ca/docs/references/scenegraph/renderable-nodes/poster.md#fields

Took me all day to figure this one out... turns out it was the frigging "PosterMask" that was causing the clipping.

@jimdogx jimdogx requested a review from cewert July 27, 2024 23:42
@jimdogx
Copy link
Contributor Author

jimdogx commented Jul 28, 2024

@cewert it occurred to me that making it smarter wouldn't be that hard after all. Plus I coded it so that it's an extra API call if (and only if) there really isn't anything to show in the Next Up home row. 👍

Ready for review again 😄

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with no crashes 👍

Some observations:

  • The episode posters are still using slaceToFit instead of scaleToZoom like the home page.
  • The View All button color is randomly grabbed every time the page is refreshed.

@jimdogx jimdogx merged commit 38cf11b into master Jul 29, 2024
10 checks passed
@jimdogx jimdogx deleted the jf-1481-next-up-all branch July 29, 2024 12:44
@p37307
Copy link

p37307 commented Jul 29, 2024

Thank you for working on this. Will make using Roku app better with my Parkinsons. I won't have to go hunt for episodes that dropped off the list. I've been hoping for this for a long time! #1481 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature that currently doesn't exist.
Projects
Development

Successfully merging this pull request may close these issues.

"View All" Next Up view
4 participants