Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite spinner bugs #1549

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Dec 4, 2023

In loadMoreData(), only show the spinner when m.Loading is false.

Changes

  • Fix lazy loading itemgrid spinner bug

@cewert cewert added the bug-fix This fixes a bug. label Dec 4, 2023
@cewert cewert requested a review from a team as a code owner December 4, 2023 14:23
@1hitsong
Copy link
Member

1hitsong commented Dec 4, 2023

Found another path to an infinite spinner. In a library click a letter or scroll down until a spinner shows. Press the back button while it's spinning. You end up on the previous view with the spinner still going.

@cewert
Copy link
Member Author

cewert commented Dec 4, 2023

I added a stopLoadingSpinner() call to the end of scenemangers popScene() function and that fixes the issue. popScene() gets called when we hit back to navigate to a previous screen in the stack. If the previous screen shows a loading spinner the spinner may flicker but I don't think there is an example of that in our app at the moment.

@cewert cewert changed the title Fix lazy loading itemgrid spinner bug Fix infinite spinner bugs Dec 4, 2023
@1hitsong 1hitsong merged commit e92d8b7 into jellyfin:unstable Dec 4, 2023
9 checks passed
@cewert cewert deleted the fix-music-library-spinner branch January 14, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants