Blurhashes #1482
Blurhashes #1482
Conversation
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
sevenrats
force-pushed
the
blurhash_v2
branch
from
c8c0fbc to
e600026
Compare
|
For what it's worth, I've just tested this on the "company" (read: Jellyfin) Roku test device - a Streaming Stick+ (3810CA, released Sept 2019) purchased in Feb 2020. I performed a normal test with the setting disabled and enabled against my test Jellyfin library, restarting the Roku device in-between setting changes, to ensure that it was starting from a cold boot. With the setting on, I did not notice any slowdowns across my local network. If there was any paging, it happened at the same points in the longer library lists, and did not appear to take any longer. If anything, it was actually nice to have the correct colours of the posters that would be loaded, instead of the template blue that stuck out when scrolling through quickly. I like this change, and would recommend it. |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
shoot bot |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired. |
|
This messes up the View All posters for TV Shows in genre view. This PR Expected |
|
I see the console print for music artists, but they don't render. It goes straight from placeholder to final rendered image. Same with music genres. |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
jellyfin-bot
added
stale
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
|
not stale. working on it still. |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
not stale |
|
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
|
oh 21 days already. when I finally finish this PR I will need to find a new way to keep track of the weeks. |
|
I'm converting this to a draft PR so the bot will stop marking this as stale. Please convert it back whenever it's ready for review again. |
enabling this new feature will raise the floor of loading time a bit, but is still probably an improvement for a large number of devices. the negative impact on loading times can be mitigated in the long term by making the number of items fetched at once configurable, and users can just turn it down when using blurhashes if they wish.