Infer server url on server select screen

source/ShowScenes.brs

@@ -252,8 +252,7 @@ function CreateServerGroup()
                 dialog = createObject("roSGNode", "ProgressDialog")
                 dialog.title = tr("Connecting to Server")
                 m.scene.dialog = dialog
-
-                serverUrl = standardize_jellyfin_url(screen.serverUrl)
+                serverUrl = inferServerUrl(screen.serverUrl)
                 'If this is a different server from what we know, reset username/password setting
                 if m.global.session.server.url <> serverUrl
                     set_setting("username", "")

source/utils/misc.brs

@@ -162,31 +162,101 @@ function option_dialog(options, message = "", defaultSelection = 0) as integer
     return show_dialog(message, options, defaultSelection)
 end function
 
-'
-' Take a jellyfin hostname and ensure it's a full url.
-' prepend http or https and append default ports, and remove excess slashes
-'
-function standardize_jellyfin_url(url as string)
-    'Append default ports
-    maxSlashes = 0
-    if left(url, 8) = "https://" or left(url, 7) = "http://"
-        maxSlashes = 2
-    end if
-    'Check to make sure entry has no extra slashes before adding default ports.
-    if Instr(0, url, "/") = maxSlashes
-        if url.len() > 5 and mid(url, url.len() - 4, 1) <> ":" and mid(url, url.len() - 5, 1) <> ":"
-            if left(url, 5) = "https"
-                url = url + ":8920"
-            else
-                url = url + ":8096"
+function inferServerUrl(url as string)
+    port = CreateObject("roMessagePort")
+    hosts = CreateObject("roAssociativeArray")
+    reqs = []
+    candidates = urlCandidates(url)
+    print "PROCESSING CANDIDATES"
+    for each endpoint in candidates
+        req = CreateObject("roUrlTransfer")
+        reqs.push(req) ' keep in scope outside of loop, else -10001
+        req.seturl(endpoint + "/system/info/public")
+        req.setMessagePort(port)
+        hosts.addreplace(req.getidentity().ToStr(), endpoint)
+        if endpoint.Left(8) = "https://"
+            req.setCertificatesFile("common:/certs/ca-bundle.crt")
+        end if
+        req.AsyncGetToString()
+    end for
+    handled = 0
+    timeout = CreateObject("roTimespan")
+    print "TIMESPAN CREATED"
+    while timeout.totalseconds() < 15
+        resp = wait(0, port)
+        if type(resp) = "roUrlEvent"
+            ' TODO
+            ' if response code is a 300 redirect then we should return the redirect url
+            ' Make sure this happens or make it happen
+            if resp.GetResponseCode() = 200
+                print "THE SELECTED URL"
+                print hosts.lookup(resp.GetSourceIdentity().ToStr())
+                print ""
+                return hosts.lookup(resp.GetSourceIdentity().ToStr())
             end if
         end if
+        handled += 1
+        if handled = reqs.count()
+            print("ALL HANDLED")
+            return ""
+        end if
+    end while
+    print "TIMED OUT"
+    ' we never actually get here but the linter can't tell
+    return ""
+end function
+
+function urlCandidates(input as string)
+    url = parseUrl(input)
+    if url[1] = invalid
+        ' a proto wasn't declared
+        url = parseUrl("none://" + input)
+    end if
+    proto = url[1]
+    host = url[2]
+    port = url[3]
+    path = url[4]
+    print ""
+    print "THE PROTO"
+    print proto
+    print "THE HOST"
+    print host
+    print "THE PORT"
+    print port
+    print "THE PATH"
+    print path
+    protoCandidates = []
+    supportedProtos = ["http:", "https:"] ' appending colons because the regex does
+    if proto = "none:" ' the user did not declare a protocol
+        ' try every supported proto
+        for each supportedProto in supportedProtos
+            protoCandidates.push(supportedProto + "//" + host)
+        end for
+    else
+        protoCandidates.push(proto + "//" + host) ' but still allow arbitrary protocols if they are declared
     end if
-    'Append http:// to server
-    if left(url, 4) <> "http"
-        url = "http://" + url
+    print "THE PROTO CANDIDATES"
+    print protoCandidates
+    final_candidates = []
+    if isValid(port) and port <> "" ' if the port is defined just use that
+        for each candidate in protoCandidates
+            final_candidates.push(candidate + port + path)
+        end for
+    else ' the port wasnt declared so use default jellyfin and proto ports
+        for each candidate in protoCandidates:
+            if candidate.startswith("https")
+                final_candidates.push(candidate + ":443" + path)
+                final_candidates.push(candidate + ":8920" + path)
+            else if candidate.startswith("http")
+                final_candidates.push(candidate + ":80" + path)
+                final_candidates.push(candidate + ":8096" + path)
+            end if
+        end for
     end if
-    return url
+    final_candidates.push(input)
+    print "FINAL CANDIDATES"
+    print final_candidates
+    return final_candidates
 end function
 
 sub setFieldTextValue(field, value)
@@ -228,15 +298,12 @@ function isValidAndNotEmpty(input as dynamic) as boolean
     end if
 end function
 
-' Returns an array from a url - [ url, proto, host, port, subdir/params ]
-' If port or subdir are not found, an empty string will be added to the array
-' Proto must be declared or array will be empty
 function parseUrl(url as string) as object
+    ' proto $1, host $2, port $3, the-rest $4
     rgx = CreateObject("roRegex", "^(.*:)//([A-Za-z0-9\-\.]+)(:[0-9]+)?(.*)$", "")
     return rgx.Match(url)
 end function
 
-' Returns true if the string is a loopback, such as 'localhost' or '127.0.0.1'
 function isLocalhost(url as string) as boolean
     ' https://stackoverflow.com/questions/8426171/what-regex-will-match-all-loopback-addresses
     rgx = CreateObject("roRegex", "^localhost$|^127(?:\.[0-9]+){0,2}\.[0-9]+$|^(?:0*\:)*?:?0*1$", "i")