Skip to content

Commit

Permalink
Fix: Remove conflicting metadata assignments to resolve audio switchi…
Browse files Browse the repository at this point in the history
…ng issue on Roku

- Removed the line `m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle` from onAudioIndexChange()
- Removed the line `m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex` from onSubtitleChange()
- These removals address a race condition causing video playback to fail when switching audio tracks

Fixes #2059
  • Loading branch information
F0x1 committed Dec 15, 2024
1 parent a3edb05 commit 1e8bbc6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions components/video/VideoPlayerView.bs
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,6 @@ sub onSubtitleChange()
m.top.control = "stop"

m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle
m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex
m.LoadMetaDataTask.itemId = m.currentItem.id
m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded")
m.LoadMetaDataTask.control = "RUN"
Expand All @@ -346,7 +345,6 @@ sub onAudioIndexChange()

m.top.control = "stop"

m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle
m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex
m.LoadMetaDataTask.itemId = m.currentItem.id
m.LoadMetaDataTask.observeField("content", "onVideoContentLoaded")
Expand Down

0 comments on commit 1e8bbc6

Please sign in to comment.