Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required from the input for API key #121

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented Mar 11, 2024

Apparently plugin does not require a subscription pin, so remove the requirement for the pin to be set.

@crobibero Should we also allow user to set their own API key and subscription pin?

@crobibero
Copy link
Member

Ah I missed removing from the html, good catch.
My understanding is that the user is required to use the project's api key, so no. The "ApiKey" field the user can change is the subscriber pin.. just poorly named

@crobibero crobibero merged commit 308b6b0 into jellyfin:master Mar 11, 2024
3 checks passed
@scampower3
Copy link
Member Author

Alright. I suppose I can rename the label to be Subscriber PIN instead since that is the terminology that TheTVDB uses?

@scampower3 scampower3 deleted the pin-not-required branch March 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants