Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVDB search fix #1

Merged
merged 2 commits into from
Nov 11, 2020
Merged

TVDB search fix #1

merged 2 commits into from
Nov 11, 2020

Conversation

Larvitar
Copy link
Contributor

Copy of #4159

Fixes several issues with TVDB plugin series search. TVDB would never run a "name only" search in GetSearchResults and GetMetadata for short series names would often return wrong results.

Changes

  1. IsValidSeries always returned true for SeriesInfo object in GetSearchResults.
  2. Never include year in search name as TVDB tends to get confused by it (see #4132).
  3. Improve search result sorting.

Issues
Fixes #4132

@crobibero
Copy link
Member

Sorry, I snuck in a change while you were migrating the PR! Thankfully it's only a style fix :)

@Larvitar
Copy link
Contributor Author

I should have checked it though. I'll resolve it in a minute :)

@Larvitar
Copy link
Contributor Author

BTW. I've noticed you've changed some instances of TvdbPlugin.ProviderName to MetadataProvider.Tvdb in d4b5b55 . Was this intentional?

@crobibero
Copy link
Member

Yes, as we move providers away from server I've been setting the ProviderName to something that doesn't rely on server.
It's the same string so the end result will be the same

@Larvitar
Copy link
Contributor Author

That's why I'm asking. MetadataProvider.Tvdb relies on the server. You've changed it to TvdbPlugin.ProviderName in the initial version of plugin but reverted 2 lines in d4b5b55 . Now we use both values in TvdbSeriesProvider.cs.

@crobibero crobibero merged commit ab94576 into jellyfin:master Nov 11, 2020
@crobibero
Copy link
Member

Fixed in master, thanks for catching that!

@Larvitar Larvitar deleted the tvdb-search-fix branch November 11, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One-word TV shows often misidentified
2 participants