Merge pull request #122 from scampower3/naming-fixes

Fixes some poorly named variables and label "for" tag fixes
jellyfin · Mar 11, 2024 · e5f3d4d · e5f3d4d
2 parents 308b6b0 + 27e7e56
commit e5f3d4d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/Jellyfin.Plugin.Tvdb/Configuration/PluginConfiguration.cs b/Jellyfin.Plugin.Tvdb/Configuration/PluginConfiguration.cs
@@ -20,7 +20,7 @@ public class PluginConfiguration : BasePluginConfiguration
         /// <remarks>
         /// This is the subscriber's pin.
         /// </remarks>
-        public string ApiKey { get; set; } = string.Empty;
+        public string SubscriberPIN { get; set; } = string.Empty;
 
         /// <summary>
         /// Gets or sets the cache in hours.

diff --git a/Jellyfin.Plugin.Tvdb/Configuration/config.html b/Jellyfin.Plugin.Tvdb/Configuration/config.html
@@ -15,21 +15,21 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                            href="https://github.com/jellyfin/jellyfin-plugin-tvdb">${Help}</a>
                     </div>
                     <div class="inputContainer">
-                        <label for="txtTvdbApiKey">TheTvdb API Key:</label>
-                        <input type="text" id="txtTvdbApiKey" is="emby-input" />
+                        <label for="txtTvdbSubscriberPIN">TheTvdb Subscriber PIN:</label>
+                        <input type="text" id="txtTvdbSubscriberPIN" is="emby-input" />
                         <div class="fieldDescription">
-                            Optional. TheTVDB Api Key from Subscriptions.
+                            Optional. TheTVDB Subscriber PIN from Subscriptions.
                         </div>
                     </div>
                     <div class="inputContainer">
-                        <label for="txtTvdbApiKey">Cache time in hours:</label>
+                        <label for="cacheDurationInHours">Cache time in hours:</label>
                         <input type="number" id="cacheDurationInHours" required="required" is="emby-input" />
                         <div class="fieldDescription">
                             The cache time in hours for metadata.
                         </div>
                     </div>
                     <div class="inputContainer">
-                        <label for="txtTvdbApiKey">Cache time in days:</label>
+                        <label for="cacheDurationInDays">Cache time in days:</label>
                         <input type="number" id="cacheDurationInDays" required="required" is="emby-input" />
                         <div class="fieldDescription">
                             The cache time in days for Languages and Activity Type metadata.
@@ -53,7 +53,7 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                 Dashboard.showLoadingMsg();
 
                 ApiClient.getPluginConfiguration(TvdbPluginConfiguration.uniquePluginId).then(function (config) {
-                    document.getElementById('txtTvdbApiKey').value = config.ApiKey || '';
+                    document.getElementById('txtTvdbSubscriberPIN').value = config.SubscriberPIN || '';
                     document.getElementById('cacheDurationInHours').value = config.CacheDurationInHours;
                     document.getElementById('cacheDurationInDays').value = config.CacheDurationInDays;
                     Dashboard.hideLoadingMsg();
@@ -64,7 +64,7 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                 Dashboard.showLoadingMsg();
 
                 ApiClient.getPluginConfiguration(TvdbPluginConfiguration.uniquePluginId).then(function (config) {
-                    config.ApiKey = document.getElementById('txtTvdbApiKey').value;
+                    config.SubscriberPIN = document.getElementById('txtTvdbSubscriberPIN').value;
                     config.CacheDurationInHours = document.getElementById('cacheDurationInHours').value;
                     config.CacheDurationInDays = document.getElementById('cacheDurationInDays').value;
                     ApiClient.updatePluginConfiguration(TvdbPluginConfiguration.uniquePluginId, config).then(function (result) {

diff --git a/Jellyfin.Plugin.Tvdb/TvdbClientManager.cs b/Jellyfin.Plugin.Tvdb/TvdbClientManager.cs
@@ -45,7 +45,7 @@ public TvdbClientManager(IApplicationHost applicationHost)
         _tokenUpdatedAt = DateTime.MinValue;
     }
 
-    private static string? UserPin => TvdbPlugin.Instance?.Configuration.ApiKey;
+    private static string? UserPin => TvdbPlugin.Instance?.Configuration.SubscriberPIN;
 
     private static int CacheDurationInHours => TvdbPlugin.Instance?.Configuration.CacheDurationInHours ?? 1;