Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the responses to several requests returns erroneous values #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FelixPetriconi
Copy link
Contributor

The comparison of the several responses with DLNA complaint servers has shown differences and were fixed accordingly

Please bare with me but I don't know much about C# or the used frameworks. Please advise how to improve the code if necessary.

I just can tell that now my Panasonic Blu-Ray player is able to connect to the Jellyfin instance.
The display of photos, streaming of mp3 and flac, and some mpg works fine.
I intent to add a working profile for that player as soon as I have found out how to get .mkv container playing.

* the comparison of the several responses with DLNA complaint servers
  has shown differences and were fixed accordingly
Copy link

@DSLinuxUser DSLinuxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried today the updates and now the Panasonic DMR-BCT750/755 is able to connect to JellyFin and plays videos back.

@FelixPetriconi
Copy link
Contributor Author

Which profile did you use? What kind of videos container did you play back?

@crobibero
Copy link
Member

I don't see how this would work as the response isn't being set to anything.

@FelixPetriconi
Copy link
Contributor Author

I cannot give you an answer to this, because I don't much about the used framework. I only can say that a response that is set to any mime type is a) not been accepted by the Panasonic player and b) it has now with this changes same result as with e.g. Emby 4.8.10 and Twonky Server 8.5.2.
I checked it on protocol level with Wireshark.

@DSLinuxUser
Copy link

Which profile did you use? What kind of videos container did you play back?

What kind of profile do you mean? Device profile?
If device profile, Jellyfin tells me in the log, that the default profile is selected.

Test was done MP4 with H264/AAC.

I don't see how this would work as the response isn't being set to anything.

Well, before this patch, the Panasonic would just throw the error "Unable to connect to server".
With this patch, it just works.

@FelixPetriconi
Copy link
Contributor Author

The same for me now.

Copy link

@DSLinuxUser DSLinuxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the changes, recompiled and replaced the DLLs and the Panasonic can still access JellyFin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants