Use file browser dialog for local path #951
Conversation
| @@ -487,6 +488,13 @@ def set_addon_mode(): | |||
| LOG.info("Add-on playback: %s", settings("useDirectPaths") == "0") | |||
|
|
|||
|
|
|||
| def strip_credentials(url): | |||
There was a problem hiding this comment.
I want this function in the test suite, so I'd minimum need a list of URLs to test, both with and without credentials in them.
http(s), cifs/smb, nfs and (s)ftp come to mind, there are probably others I'm forgetting.
I can write the tests myself, but I need help gathering a diverse set of example URLs (that represent your real world application) – take what you have, but replace with example/documentation IP addresses and domain names, and anonymize paths if needed (but keep the overall structure).
The above is a note for anyone using native mode, especially those with more esoteric setups.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 21.83% 21.88% +0.04%
==========================================
Files 63 63
Lines 8677 8682 +5
Branches 1411 1411
==========================================
+ Hits 1895 1900 +5
Misses 6763 6763
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
|
I added some test cases. Personally I could only test nfs and smb but I don't see why the other types would not work. |
Use a file browser dialog instead of a basic plaintext dialog for the local path. Kodi returns credentials for instance in smb paths selected using a browser dialog. It's better to strip these out so they do not become visible in the list.