-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve HEVC codec handling in transcoding profiles #895
Improve HEVC codec handling in transcoding profiles #895
Conversation
add test scenario for the jellyfin#893
6bd2129
to
ca49333
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 21.50% 21.86% +0.36%
==========================================
Files 63 63
Lines 8632 8630 -2
Branches 1585 1585
==========================================
+ Hits 1856 1887 +31
+ Misses 6755 6724 -31
+ Partials 21 19 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to my earlier comments around the tests.
Quality Gate passedIssues Measures |
This PR refines the logic for handling HEVC codec preferences in transcoding profiles, ensuring more consistent and codec selection.
Fixes #893
Changes
get_transcoding
methodsDetails
The codec list is now handled as follows:
settings("transcode_h265.bool")
is False, "hevc" is added to the listsettings("videoPreferredCodec")
is "H265/HEVC":This ensures that:
Additional Notes
Fixes #893